perf(registry): bound component file cache with lru-cache and add cacheMaxSize config#1483
Open
ricardo-devis-agullo wants to merge 2 commits into
Open
perf(registry): bound component file cache with lru-cache and add cacheMaxSize config#1483ricardo-devis-agullo wants to merge 2 commits into
ricardo-devis-agullo wants to merge 2 commits into
Conversation
…heMaxSize config Replace the unbounded nice-cache in get-component with lru-cache so compiled templates, data providers and env files are evicted after reaching cacheMaxSize (default 100). Also avoid shallow-cloning every component detail map in components-details when nothing has changed. - Add lru-cache@^10.4.3 dependency, remove nice-cache - Add cacheMaxSize config option with sanitiser default - Update tests for the new config default
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
…gistry-cache # Conflicts: # package-lock.json # packages/oc/package.json
Contributor
Done. Resolved the merge conflicts in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the unbounded nice-cache in get-component with lru-cache so
compiled templates, data providers and env files are evicted after
reaching cacheMaxSize (default 100). Also avoid shallow-cloning every
component detail map in components-details when nothing has changed.