Skip to content

Consistent list annotation - #959

Open
Hemant27031999 wants to merge 8 commits into
opencobra:develfrom
Hemant27031999:ConsistentListAnnotation
Open

Consistent list annotation#959
Hemant27031999 wants to merge 8 commits into
opencobra:develfrom
Hemant27031999:ConsistentListAnnotation

Conversation

@Hemant27031999

Copy link
Copy Markdown
Contributor

This PR is solving issue #736 and #706. A new function _fix_annotation() has been added which fixes the incorrect annotation format.

@codecov-commenter

codecov-commenter commented Jun 4, 2020

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.45%. Comparing base (d362f51) to head (351d5c3).
⚠️ Report is 868 commits behind head on devel.

Files with missing lines Patch % Lines
cobra/io/dict.py 83.33% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #959      +/-   ##
==========================================
- Coverage   84.63%   84.45%   -0.18%     
==========================================
  Files          50       50              
  Lines        4438     4459      +21     
  Branches      998     1006       +8     
==========================================
+ Hits         3756     3766      +10     
- Misses        441      449       +8     
- Partials      241      244       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Midnighter

Copy link
Copy Markdown
Member

Hey @Hemant27031999, this is good work but unfortunately, I don't think we can merge it without a change to the JSON schema. As you can read in #967, I would love to refactor this functionality into a separate package. And even if we don't do that, I think the JSON schema should be generated from pydantic models rather than crafted by hand. So I'm afraid, I can't merge this PR at this point as it is blocked.

@cdiener cdiener added the stale The issue or pull request lacks activity. label Sep 1, 2021
@cdiener cdiener removed the blocked label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale The issue or pull request lacks activity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants