fix memory leak: ensure hooks are cleaned up on exception in find_alignment - #2681
Open
virajsabhaya23 wants to merge 1 commit into
Open
fix memory leak: ensure hooks are cleaned up on exception in find_alignment#2681virajsabhaya23 wants to merge 1 commit into
virajsabhaya23 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Critical Memory Leak in Word-Level Timestamp Alignment
Problem Identified
find_alignment()function causing hooks to persist on exceptionRoot Cause Analysis
whisper/timing.py, lines 187-204○ Hooks remain attached to cross-attention layers on failure
○ Memory consumption increases with each failed alignment attempt
○ Model state becomes polluted across subsequent inference calls
○ Performance degradation in production environments
Solution Implemented
Technical Details
find_alignment()○
tryblock wraps model forward pass and attention weight extraction○
finallyblock ensures all registered hooks are removed○ Exception-safe cleanup prevents memory leaks
○ No performance impact on normal execution path