examples(SingleStoreDB): migrate notebook to openai>=1.0 client API - #2718
Open
kiwigitops wants to merge 2 commits into
Open
examples(SingleStoreDB): migrate notebook to openai>=1.0 client API#2718kiwigitops wants to merge 2 commits into
kiwigitops wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c44f4cc8d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
3 tasks
This was referenced May 29, 2026
Author
|
Quick follow-up on this. I addressed the API key issue after review; if this direction still makes sense, I can refresh it against main since it's showing non-mergeable now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/vector_databases/SingleStoreDB/OpenAI_wikipedia_semantic_search.ipynbstill uses the pre-v1 OpenAI Python SDK API (openai.ChatCompletion.create,openai.api_key = ...,response["choices"][0]["message"]["content"]). The pre-v1 API was removed inopenai>=1.0.0, so this notebook fails immediately for any user who installs the current SDK:This PR migrates the affected cells to the v1+ client API. No behavioral changes — same model (
gpt-3.5-turbo), same prompts, same temperature.Changes
The embeddings helper used elsewhere in this notebook is already on the v1+ API, so the rest of the flow works as soon as the chat calls are migrated.
Test plan
openai.ChatCompletion.create,openai.api_key =, or dict-styleresponse[...]access in any code cell.