RFC-4: Add MUST's for type field#329
Merged
Merged
Conversation
Also clarify it is a string and the only currently defined value is "anatomical".
Contributor
Automated Review URLs |
Merged
melonora
approved these changes
Sep 8, 2025
melonora
left a comment
melonora
left a comment
Contributor
There was a problem hiding this comment.
Thanks! I think the description is clear and in line with current ome-ngff spec descriptions.
Member
|
Merging but two quick points:
|
thewtex
added a commit
to thewtex/ngff
that referenced
this pull request
Sep 23, 2025
Member
Author
|
@joshmoore thanks for the review / merge. Changelog entries added in #340 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also clarify it is a string and the only currently defined value is
"anatomical".