Leica SCN: update list of scanner models without color correction#4439
Open
melissalinkert wants to merge 1 commit into
Open
Leica SCN: update list of scanner models without color correction#4439melissalinkert wants to merge 1 commit into
melissalinkert wants to merge 1 commit into
Conversation
sbesson
approved these changes
Jun 22, 2026
sbesson
left a comment
sbesson
left a comment
Member
There was a problem hiding this comment.
The proposed change is in the spirit of #3562 where we are maintaining a list of models which must include a YCbCr correction.
Using the provided sample SCN file uploaded as part of the issue, with Bio-Formats 8.5.0, any resolution (e.g. third resolution of the second series below) renders as pink
With this PR included, the image renders as expected:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4420.
Without this change,
showinf -noflaton https://zenodo.org/records/19009239 should show pink images. With this change, the images should look normal.This doesn't seem to impact existing Leica SCN test data when checking locally, but waiting for a passing nightly build before assigning for review.
I debated going ahead and adding a reader option to override the list of models as well, but I'm not sure how useful that would end up being in general. Thoughts welcome.