Make displaying python version glyph in virtualenv segment configurable#346
Open
w-biggs wants to merge 4 commits into
Open
Make displaying python version glyph in virtualenv segment configurable#346w-biggs wants to merge 4 commits into
w-biggs wants to merge 4 commits into
Conversation
Member
|
So with this change it shows the glyph if you're in a virtualenv, but no version number? For other similar things we change the binary yes/no to include an option like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: On my machine,
python --versionis taking 664ms to execute; this is then getting tacked onto every single shell command due to__bobthefish_prompt_virtualfishcallingpython --versionto decide which version glyph to display. I'm not sure ifpython --versionis simply not supposed to take that long, but I find it useful to have the current virtualenv displayed regardless, so making this configurable seems like the best route.$theme_display_virtualenv_python_versionis checked twice because I figured it was best to preserve the current behavior of "if the python version doesn't match any case, don't display the virtualenv color and glyph at all".