Skip to content

add new theme: powerline-shell wrapper for fish#102

Open
leleliu008 wants to merge 1 commit into
oh-my-fish:masterfrom
leleliu008:master
Open

add new theme: powerline-shell wrapper for fish#102
leleliu008 wants to merge 1 commit into
oh-my-fish:masterfrom
leleliu008:master

Conversation

@leleliu008

Copy link
Copy Markdown

add new theme: powerline-shell wrapper for fish

@leleliu008 leleliu008 requested a review from a team as a code owner October 3, 2019 14:12
@derekstavis

Copy link
Copy Markdown
Member

Would you mind removing the -theme from the end of the filename? It's not necessary because the package type is defined by the package definition file.

@leleliu008

Copy link
Copy Markdown
Author

@derekstavis can't remove the -theme from the end of the filename for the following reasons:

  1. a package who is named powerline which type is plugin already exist. it is wrapped for powerline-status
  2. my new package's type is theme, it is wrapped for powerline-shell

@bobthecow

Copy link
Copy Markdown
Member

installing this theme sets fish keybindings to vi mode (and this persists even after removing the theme). this feels like … not the sort of thing a theme should do :)

@leleliu008

Copy link
Copy Markdown
Author

@bobthecow I have removed the key_bindings.fish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants