fix(om_account_budget): replace _where_calc/_apply_ir_rules with read…#196
Open
Aadarsh-06 wants to merge 1 commit into
Open
fix(om_account_budget): replace _where_calc/_apply_ir_rules with read…#196Aadarsh-06 wants to merge 1 commit into
Aadarsh-06 wants to merge 1 commit into
Conversation
…_group for Odoo 19 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the deprecated _where_calc() and _apply_ir_rules() raw SQL pattern in _compute_practical_amount with the ORM read_group() API, fixing compatibility with Odoo 19.
Changes
account.analytic.line amount query now uses read_group(domain, ['amount:sum'], [])
account.move.line credit/debit query now uses read_group(domain, ['credit:sum', 'debit:sum'], [])
Removed manual raw SQL execution via env.cr.execute()
Why
_where_calc() and _apply_ir_rules() were removed in Odoo 17+ and cause errors in Odoo 19. The read_group() replacement is the idiomatic ORM approach and handles security rules automatically.