publish: name the app in the GitHub release title - #159
Merged
Conversation
The release step titled every release with the bare tag, so the page read 'v1.0.11'. This repo ships more than one app — bento/spaces and bento/dash are starting — and a page titled with a version alone does not say which one the file below it is. v1.0.6 was titled by hand as 'Bento/Slides v1.0.6' and got this right. Every release after it went through this automated step and came out as a bare tag, which is how the convention was lost. The six existing releases have been retitled to 'bento/slides vX.Y.Z' (matching doc.type and the docs/PLATFORM.md spelling); hardcoding the title here is what stops it drifting a second time. The die() hint now prints the same title, so the manual recovery command produces a correctly-titled release too.
nyblnet
force-pushed
the
fix-release-title
branch
from
July 27, 2026 22:18
177d78f to
ec73917
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release step passed
'--title', tag, so every automated release page readv1.0.11— a version with no app name on it. This repo ships more than one app (bento/spacesandbento/dashare starting), so that page does not say which one the attached file is.v1.0.6was titled by hand asBento/Slides v1.0.6and got this right. Every release from v1.0.7 onward went through this line and came out as a bare tag, which is exactly how the convention was lost — the same shape as the notes regression in #158: the automated path silently did something worse than the manual one it replaced.The six existing releases have been retitled to
bento/slides vX.Y.Z, matchingdoc.typeand thedocs/PLATFORM.mdspelling. Verified after retitling: notes and the signed shell asset are intact on each.This PR stops it drifting again. The
die()hint prints the same title, so the manual recovery command produces a correctly-titled release too.When Spaces ships its own release channel it will want its own title — the constant is per-app and sits next to the per-app
releaseShellpath, so that stays a one-line change.