Python 3.12 compatibility fixes for shell history parsing and history filtering - #1610
Open
olucasfracaro wants to merge 5 commits into
Open
Python 3.12 compatibility fixes for shell history parsing and history filtering#1610olucasfracaro wants to merge 5 commits into
olucasfracaro wants to merge 5 commits into
Conversation
olucasfracaro
force-pushed
the
python312-support
branch
from
July 2, 2026 02:47
0606134 to
b502c74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the remaining Python 3.12 issues I found while running the test suite locally.
What was fixed
Fish/Tcsh history parsing
get_history()infish.pyandtcsh.pyto read history viaio.open(...).readlines(), matching current test fixtures and avoiding empty history results in tests.History filtering in
utils.pyget_valid_history_without_current()filtering to:café ô)nocommand x)Validation
Ran locally on Python 3.12.3:
pytest tests/shells -q✅1887 passed, 62 skipped✅Related