docs(design): key-picker rethink design note (#16)#26
Merged
Conversation
Capture the design for inverting the binding editor so the behavior is derived from filled Hold/Tap slots instead of selected first. Grounds the issue #16 proposal in the current code (component names, line refs, the BehaviorMap data model) and lays out the staged 1-PR-per-step plan, capability-awareness, edge cases (polymorphic hold slot, implicit-modifier encoding, invalid-combination states, migration dual-UI sync) and open questions. Design only; no behavior change. Refs #16. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the working design note for issue #16: inverting the binding editor so the behavior is derived from filled Hold/Tap slots instead of selected first.
What this is
docs/design/key-picker-rethink.md— a codebase-grounded expansion of the issue:BehaviorBindingPicker,BehaviorParametersPicker, theHidUsagePickergrid) with line refs and theBehaviorMapdata model.&kp/&mt/</&mo/&none).Design only — no code change. Step 1 lands separately.
Credit to upstream
zmkfirmware/zmk-studio(Apache-2.0); direction is adjacent to upstream PR zmkfirmware#159 (Grid Picker for HID Usage). Anything fork-specific stays here.Refs #16.
🤖 Generated with Claude Code