Skip to content

ci: Update workflows to follow upstream conventions - #22

Merged
papazof merged 5 commits into
mainfrom
ci_update_workflows
Apr 24, 2026
Merged

ci: Update workflows to follow upstream conventions#22
papazof merged 5 commits into
mainfrom
ci_update_workflows

Conversation

@papazof

@papazof papazof commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Update CI workflows to follow upstream conventions and test examples:

  • Add workflow to append git trailers to PR commits
  • Add test for examples, update dependencies and run tests in CI
  • Lint non-Go files
  • Update dependabot config to check GitHub actions
  • Remove redundant cgo directives and fix updated linter errors

@papazof
papazof force-pushed the ci_update_workflows branch 3 times, most recently from ba54936 to 1f6ca93 Compare April 10, 2026 06:47
Comment thread .github/workflows/pr-build-and-verify.yml Fixed
Comment thread .github/workflows/pr-build-and-verify.yml Fixed
Comment thread .github/workflows/pr-build-and-verify.yml Fixed
Comment thread .github/workflows/pr-build-and-verify.yml Fixed
Comment thread .github/workflows/pr-build-and-verify.yml Fixed
@papazof
papazof force-pushed the ci_update_workflows branch 3 times, most recently from 9cf7d98 to 4329733 Compare April 10, 2026 18:53
@papazof
papazof force-pushed the ci_update_workflows branch from 4329733 to f8c9c6e Compare April 23, 2026 19:54
@papazof
papazof marked this pull request as ready for review April 24, 2026 19:37
@papazof
papazof requested a review from ananos April 24, 2026 19:37
papazof added 5 commits April 24, 2026 20:40
Add test for examples and update dependencies:
- Add test that runs examples and checks their output
- Simplify makefile for building examples and use shell pkg-config paths
- Fix tf print identation by adding spaces instead of zero-valued runes
- Replace archived `github.com/nfnt/resize` with
  `golang.org/x/image/draw` in torch example
- Remove `exec_genop` example since the `vaccel_arg_list` API is
  deprecated and does not work correctly with `genop` anymore
- Fix linter errors for current Go

PR: #22
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Refactor CI workflows to follow upstream conventions:
- Add workflow to append git trailers to PR commits
- Run tests in CI
- Use super-linter to lint non-Go files
- Update dependabot config to check GitHub Actions dependencies, group
  dependency updates and set Go module checks to monthly interval

PR: #22
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Move common cgo directives into a single file and remove redundant
directives

PR: #22
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Disable gocritic's `dupSubExpr` check globally and remove individual
`nolint` comments, since it is a common false positive in cgo code

PR: #22
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
Replace tabs with spaces in docs

PR: #22
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@vaccel-bot
vaccel-bot Bot force-pushed the ci_update_workflows branch from f8c9c6e to 712f87a Compare April 24, 2026 20:40
@papazof
papazof merged commit f1a1d3d into main Apr 24, 2026
10 checks passed
papazof added a commit that referenced this pull request Apr 24, 2026
Add test for examples and update dependencies:
- Add test that runs examples and checks their output
- Simplify makefile for building examples and use shell pkg-config paths
- Fix tf print identation by adding spaces instead of zero-valued runes
- Replace archived `github.com/nfnt/resize` with
  `golang.org/x/image/draw` in torch example
- Remove `exec_genop` example since the `vaccel_arg_list` API is
  deprecated and does not work correctly with `genop` anymore
- Fix linter errors for current Go

PR: #22
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
papazof added a commit that referenced this pull request Apr 24, 2026
Refactor CI workflows to follow upstream conventions:
- Add workflow to append git trailers to PR commits
- Run tests in CI
- Use super-linter to lint non-Go files
- Update dependabot config to check GitHub Actions dependencies, group
  dependency updates and set Go module checks to monthly interval

PR: #22
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
papazof added a commit that referenced this pull request Apr 24, 2026
Move common cgo directives into a single file and remove redundant
directives

PR: #22
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
papazof added a commit that referenced this pull request Apr 24, 2026
Disable gocritic's `dupSubExpr` check globally and remove individual
`nolint` comments, since it is a common false positive in cgo code

PR: #22
Signed-off-by: Kostis Papazafeiropoulos <papazof@gmail.com>
Reviewed-by: Anastassios Nanos <ananos@nubificus.co.uk>
Approved-by: Anastassios Nanos <ananos@nubificus.co.uk>
@papazof
papazof deleted the ci_update_workflows branch April 24, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants