Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion papermill/tests/test_execute.py
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,6 @@ def test_output_formatting(self):
# exception should be thrown by now
self.assertFalse(True)
except PapermillExecutionError as ex:
self.assertEqual(ex.traceback[1], "\x1b[0;31mSystemExit\x1b[0m\x1b[0;31m:\x1b[0m 1\n")
Comment thread
rgbkrk marked this conversation as resolved.
self.assertEqual(strip_color(ex.traceback[1]), "SystemExit: 1\n")

nb = load_notebook_node(result_path)
Expand Down
4 changes: 2 additions & 2 deletions papermill/tests/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def test_chdir():
old_cwd = Path.cwd()
with TemporaryDirectory() as temp_dir:
with chdir(temp_dir):
assert Path.cwd() != old_cwd
assert Path.cwd() == Path(temp_dir)
assert Path.cwd().resolve() != old_cwd.resolve()
assert Path.cwd().resolve() == Path(temp_dir).resolve()

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this failed on macOS


assert Path.cwd() == old_cwd
4 changes: 3 additions & 1 deletion requirements/azure.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
azure-datalake-store >= 0.0.30
# newer versions require changes to authentication
# see https://github.com/nteract/papermill/issues/825
azure-datalake-store >= 0.0.30,<1.0.0a0
azure-storage-blob >= 12.1.0
requests >= 2.21.0
azure-identity>=1.3.1
3 changes: 2 additions & 1 deletion requirements/dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ botocore
codecov
coverage
google_compute_engine # Need this because boto has issues with dynamic package loading during tests if other google components are there
ipython>=5.0
# newer versions of ipython have different imports and require refactoring
ipython>=5.0,<9.0.0

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the other test failure was caused by an import error

ipywidgets
notebook
moto >= 5.0.0,<5.1.0
Expand Down
Loading