Allow skip it too slow to fetch crash report - #449
Merged
kylebonnici merged 4 commits intoAug 20, 2026
Conversation
kylebonnici
added
doc not required
kylebonnici
force-pushed
the
cloud-first-skip-crash-report
branch
from
August 19, 2026 20:04
bd37978 to
0ac8e37
Compare
formalmia
previously requested changes
Aug 20, 2026
formalmia
left a comment
formalmia
left a comment
Contributor
There was a problem hiding this comment.
I think the stopwatch handling doesn't handle all cases and currently allows us to get into a bad state (as described in my comment).
I think alternatively we can also use a timeout, which seems more suited to this (we do not use the actual passing of time for anything). Though practically it wouldn't make much difference (apart from maybe saving us about 3 lines of code). I'd personally prefer it though.
formalmia
reviewed
Aug 20, 2026
kylebonnici
force-pushed
the
split/baseline-polling
branch
from
August 20, 2026 12:59
de5f650 to
3c2ec96
Compare
kylebonnici
force-pushed
the
cloud-first-skip-crash-report
branch
from
August 20, 2026 12:59
af4c6e0 to
4388de6
Compare
Co-authored-by: Mia Rosie Lleorenig <279646534+formalmia@users.noreply.github.com>
kylebonnici
force-pushed
the
split/baseline-polling
branch
from
August 20, 2026 13:14
3c2ec96 to
9375234
Compare
kylebonnici
force-pushed
the
cloud-first-skip-crash-report
branch
from
August 20, 2026 13:14
cd0614a to
8a0dfc3
Compare
* Set bt device name * Feeback * Feeback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.