-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add LineBreakMode to NiceButton with orientation-aware wrapping #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
2fbc5a0
docs: add spec for NiceButton LineBreakMode (#31)
7a79a03
docs: revise NiceButton LineBreakMode spec after review
ee96b9f
docs: add implementation plan for NiceButton LineBreakMode (#31)
ef83c0a
docs: revise implementation plan after review (no layout mutations in…
2e4449f
docs: incorporate review feedback (WrapsText flag, textColumnWidth re…
de4f218
feat: add LineBreakMode BindableProperty to NiceButton
a752631
feat: drive NiceButton column layout from EffectiveLineBreakMode in R…
b6f939d
feat: two-pass measure for WordWrap in NiceButtonLayoutManager
2110708
docs: document LineBreakMode property in NiceButton table
104176b
feat: add ButtonsPage with LineBreakMode smoke tests to demo app
3c32c02
feat: add S7-S10 icon smoke tests to ButtonsPage
d011b1a
fix: constrain NiceButton text column so truncation engages and icons…
72bda6d
fix: center icon+text as a unit and cap label width for wrap/ellipsis
73efef6
refactor: remove orphaned NiceButton demo members from MainViewModel
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.