chore: bump sdk math package from retracted version - #63
Conversation
WalkthroughDependency-only updates across multiple go.mod files: Changes
Sequence Diagram(s)(No sequence diagrams provided — changes are dependency/version updates only and do not alter control flow.) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
go.mod (1)
1-50: Inconsistent Go version specifications across modules.root go.mod and simapp/go.mod remain at
go 1.24, while tool/go.mod and e2e/go.mod are bumped togo 1.24.0. For consistency and clarity, consider updating all modules to the same Go version specification (either all1.24or all1.24.0).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
e2e/go.sumis excluded by!**/*.sumgo.sumis excluded by!**/*.sumgo.workis excluded by!**/*.worksimapp/go.sumis excluded by!**/*.sum
📒 Files selected for processing (4)
e2e/go.mod(1 hunks)go.mod(1 hunks)simapp/go.mod(1 hunks)tool/go.mod(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-25T10:35:00.822Z
Learnt from: CR
Repo: noble-assets/orbiter PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-08-25T10:35:00.822Z
Learning: Applies to **/*.go : Go code must be formatted and pass golangci-lint
Applied to files:
tool/go.mod
📚 Learning: 2025-10-13T11:49:11.266Z
Learnt from: MalteHerrmann
Repo: noble-assets/orbiter PR: 49
File: controller/adapter/ibc.go:74-81
Timestamp: 2025-10-13T11:49:11.266Z
Learning: In the orbiter codebase, when packet parsing determines a packet is not intended for the orbiter module (e.g., invalid ICS-20 data or wrong receiver), return a typed sentinel error `core.ErrNoOrbiterPacket` instead of (nil, nil). Callers should check with `errors.Is(err, core.ErrNoOrbiterPacket)` to implement fallback behavior, avoiding nil pointer panics and making intent explicit.
Applied to files:
e2e/go.mod
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: unit-test
- GitHub Check: prepare
- GitHub Check: build
- GitHub Check: lint
🔇 Additional comments (5)
tool/go.mod (1)
3-3: Go version specification is more explicit.Bumping to
go 1.24.0is good for pinning exact toolchain requirements. However, note that root go.mod and simapp/go.mod remain atgo 1.24(see earlier comment about inconsistency).e2e/go.mod (2)
7-7: Verify cosmossdk.io/math v1.5.3 release and check for security advisories.The patch upgrade to v1.5.3 aligns with updates in other modules. Ensure the release is valid and has no known CVEs.
3-3: Go version pinned to exact patch level.The bump from
go 1.24togo 1.24.0aligns with tool/go.mod. This is consistent with the broader effort to specify exact toolchain versions.simapp/go.mod (1)
38-38: No issues found — cosmossdk.io/math v1.5.3 is valid and unaffected by known vulnerabilities.v1.5.3 is the latest released version published Apr 4, 2025. The known security advisory ASA-2024-010 / GHSA-7225-m954-23v7 affected cosmossdk.io/math <= v1.3.0 and was patched in v1.4.0. Since v1.5.3 is released after this patch, the dependency is free from this CVE.
go.mod (1)
12-12: cosmossdk.io/math v1.5.3 is valid and secure—no action required.v1.5.3 was released on April 4, 2025, and no CVE is listed for this version; the only known public advisory (ASA-2024-010) affects v1.3.0 and earlier, patched in v1.4.0.
Summary by CodeRabbit