added explicit instantiations of 'has_from_json' and 'has_to_json' for std_fs::path#5209
Open
drcosmin wants to merge 2 commits into
Open
added explicit instantiations of 'has_from_json' and 'has_to_json' for std_fs::path#5209drcosmin wants to merge 2 commits into
drcosmin wants to merge 2 commits into
Conversation
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @drcosmin |
…r std_fs::path; Signed-off-by: drcosmin <cosmin.dr@pm.me>
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @drcosmin |
nlohmann
requested changes
Jun 15, 2026
Signed-off-by: drcosmin <cosmin.dr@pm.me>
drcosmin
commented
Jun 16, 2026
Owner
|
Please update to the latest develop branch which fixes the ci_module_cpp20 job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4996
TLDR:
In recent MSVC compiler versions, complex templates fail resolution. Workaround: perform explicit instantiations prior to use
Background
I had this happen in production code more on several occasions, and every time the only solution we could find was doing explicit instantiations. It started with one compiler version from VS2022, so it's not a new issue.
There are several posts on the dev community and Microsoft claims to have solved the issue, but, in my experience, this is still happening
https://developercommunity.visualstudio.com/t/failed-to-specialize-alias-template-error-after-up/1667151
Solution (implemented here)
Just instantiate the trait manually
Possible changes