STY: Prefer avoiding private import statements in tests - #471
Open
jhlegarreta wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Not sure if there was a reason for private import statements. We can also import all classes at the top if we prefer that over the need to fully resolve the names every time. |
jhlegarreta
force-pushed
the
sty/prefer-avoiding-private-imports
branch
2 times, most recently
from
July 23, 2026 19:17
98650cf to
5a9dada
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 90.30% 90.30%
=======================================
Files 38 38
Lines 2207 2207
Branches 251 251
=======================================
Hits 1993 1993
Misses 187 187
Partials 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Prefer avoiding private import statements in tests. Improves consistency throughout the test by resolving names wherever they are needed, since only the `model` package is imported.
jhlegarreta
force-pushed
the
sty/prefer-avoiding-private-imports
branch
from
July 23, 2026 19:45
5a9dada to
fd5565b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer avoiding private import statements in tests.
Improves consistency throughout the test by resolving names wherever they are needed, since only the
modelpackage is imported.