TST: Prefer using the DWI dataset generation fixture - #469
Open
jhlegarreta wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@oesteban If there is a reason to require a particular distribution, then maybe we can modify the fixture so that we can specify the desired distribution? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
=======================================
Coverage 90.30% 90.30%
=======================================
Files 38 38
Lines 2207 2207
Branches 251 251
=======================================
Hits 1993 1993
Misses 187 187
Partials 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jhlegarreta
force-pushed
the
tst/prefer-using-dwi-fixture
branch
from
July 23, 2026 19:18
ba7303d to
d1fd28d
Compare
Prefer using the DWI dataset generation fixture: the `test_gpmodel_fit_predict` and `test_single_fit_canary_warning` test functions do not check whether the predictions match some expected value; rather, they verify that the LOVO and single-fit execution paths provide non-null and finite results, and emit warnings as necessary. Avoids adding boilerplate code.
jhlegarreta
force-pushed
the
tst/prefer-using-dwi-fixture
branch
from
July 23, 2026 19:46
d1fd28d to
752094a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer using the DWI dataset generation fixture: the
test_gpmodel_fit_predictandtest_single_fit_canary_warningtest functions do not check whether the predictions match some expected value; rather, they verify that the LOVO and single-fit execution paths provide non-null and finite results, and emit warnings as necessary.Avoids adding boilerplate code.