perf: add willReadFrequently hint to canvas context#270
Open
VoidArchive wants to merge 1 commit into
Open
Conversation
Fixes Chrome warning about multiple getImageData readback operations. This optimization hint tells the browser to prepare for frequent pixel reads, improving performance for QR scanning. Fixes nimiq#236 Fixes nimiq#251 3. PR title: perf: add willReadFrequently hint to canvas context 4. PR description: ## Summary Adds `willReadFrequently: true` to the canvas 2D context creation to eliminate the Chrome warning and potentially improve scanning performance. ## Problem Chrome shows this warning during QR scanning: > Canvas2D: Multiple readback operations using getImageData are faster with > the willReadFrequently attribute set to true. ## Solution Add the `willReadFrequently: true` option when creating the canvas context in `_drawToCanvas()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
willReadFrequently: trueto the canvas 2D context creation to eliminate the Chrome warning and potentially improve scanning performance.Problem
Chrome shows this warning during QR scanning:
Solution
Add the
willReadFrequently: trueoption when creating the canvas context in_drawToCanvas().Browser Support
The
willReadFrequentlyoption is supported in all modern browsers:For older browsers, the option is simply ignored (no breaking change).
Fixes #236
Fixes #251