build: harden 1.1.2 verification flow#15
Conversation
Deploying doubleducklab with
|
| Latest commit: |
010d604
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://29bf96d2.doubleducklab.pages.dev |
| Branch Preview URL: | https://codex-1-1-2-stability.doubleducklab.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR hardens the release verification flow by consolidating validation/build/tests into a single npm run verify entrypoint, keeping Windows (verify.bat) and CI aligned while ensuring builds run from clean artifacts.
Changes:
- Replaced the multi-step
verify.batflow with a singlenpm run verifycall. - Added
scripts/verify.mjsto runvalidate:content,build,test:smoke, andtest:seosequentially with fail-fast behavior. - Hardened
buildby introducingscripts/build-site.mjs(cleandist/+ default telemetry disable) and updated CI/docs/READMEs to useverify.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| verify.bat | Delegates verification to npm run verify for Windows parity. |
| scripts/verify.mjs | Implements the unified, sequential verification pipeline. |
| scripts/build-site.mjs | Enforces clean builds and disables Astro telemetry by default. |
| package.json | Adds verify script and routes build through the hardened build wrapper. |
| package-lock.json | Bumps package version metadata to 1.1.2. |
| .github/workflows/ci.yml | Replaces individual CI steps with npm run verify. |
| CHANGELOG.md | Documents 1.1.2 stability hardening changes. |
| README.md / README_EN.md | Updates verification docs to the unified verify entrypoint. |
| docs/*, content-map.md | Updates operational/release/docs checklists to use npm run verify. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 010d604475
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| process.env.ASTRO_TELEMETRY_DISABLED = '1'; | ||
| } | ||
|
|
||
| const result = spawnSync(process.execPath, [astroEntry, 'build'], { |
There was a problem hiding this comment.
build used to execute astro build directly, so npm run build -- --mode staging (and similar flags) reached Astro. The new wrapper hardcodes ['build'] and never forwards process.argv.slice(2), so any caller-provided build options are silently dropped. This can produce incorrect artifacts (for example, wrong mode-specific env/config during release verification) when teams rely on build-time flags.
Useful? React with 👍 / 👎.
No description provided.