Skip to content

fix(web): use daemon MCP install info in agent guide - #4865

Merged
AmyShang-alt merged 1 commit into
nexu-io:mainfrom
YOMXXX:fix/issue-4852-mcp-guide-launcher
Jul 2, 2026
Merged

fix(web): use daemon MCP install info in agent guide#4865
AmyShang-alt merged 1 commit into
nexu-io:mainfrom
YOMXXX:fix/issue-4852-mcp-guide-launcher

Conversation

@YOMXXX

@YOMXXX YOMXXX commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Fixes #4852

Why

I hit this while reviewing the Windows packaged-app MCP setup path. The Use Everywhere copied guide still included a generic "command": "od" MCP config, but Windows packaged installs may not expose an od binary on PATH.

The daemon already exposes the working launch tuple through /api/mcp/install-info. The handoff guide should use that same source so pasted MCP config can start the server in packaged installs.

What users will see

Opening Use Everywhere and copying the agent guide now includes the daemon-reported MCP command, args, and env. On Windows packaged installs, the copied JSON points at the absolute Open Design executable/CLI script and preserves env such as ELECTRON_RUN_AS_NODE and OD_DATA_DIR, instead of telling agents to spawn bare od.

Surface area

  • UI — new page / dialog / panel / menu item / setting / empty state in apps/web or apps/desktop (including Electron menu bar)
  • Keyboard shortcut — new or changed
  • CLI / env var — new od subcommand or flag, new tools-dev / tools-pack / tools-pr flag, or new OD_* env var
  • API / contract — new /api/* endpoint, new SSE event, or changed shape in packages/contracts
  • Extension point — new entry under skills/, design-systems/, design-templates/, or craft/, or change to the skills protocol
  • i18n keys — added new translation keys (see TRANSLATIONS.md for the locale workflow)
  • New top-level dependency — adding any new entry to the root package.json (dependencies or devDependencies); workspace-package package.json files are out of scope. Include a paragraph on what we get vs. what bytes we ship (see CONTRIBUTING.md → Code style)
  • Default behavior change — changes what existing users experience without opting in (default model, default setting, file/SQLite schema, auto-network on startup, auto-install)
  • None — internal refactor, docs, tests, or translation update only

Screenshots

No screenshot attached. This changes copied markdown generated from the existing Use Everywhere panel, not the visual layout. The clipboard path is covered by apps/web/tests/components/use-everywhere-copy-guide.test.tsx.

Bug fix verification

  • Test path that reproduces the bug: apps/web/tests/components/use-everywhere-agent-guide.test.ts, apps/web/tests/components/use-everywhere-copy-guide.test.tsx
  • Did the test go red on main and green on this branch? yes — the regression covered the copied guide still emitting "command": "od" instead of the daemon install-info launch spec.

Validation

  • PATH=/Users/liguanchen/.nvm/versions/node/v24.15.0/bin:$PATH pnpm --filter @open-design/web exec vitest run -c vitest.config.ts --maxWorkers=2 tests/components/use-everywhere-agent-guide.test.ts tests/components/use-everywhere-copy-guide.test.tsx — 2 files / 11 tests passed
  • PATH=/Users/liguanchen/.nvm/versions/node/v24.15.0/bin:$PATH pnpm --filter @open-design/web typecheck
  • PATH=/Users/liguanchen/.nvm/versions/node/v24.15.0/bin:$PATH pnpm guard
  • PATH=/Users/liguanchen/.nvm/versions/node/v24.15.0/bin:$PATH pnpm typecheck

@lefarcen
lefarcen requested a review from mrcfps June 28, 2026 15:43
@lefarcen lefarcen added size/M PR changes 100-300 lines risk/medium Medium risk: regular code changes type/bugfix Bug fix needs-validation Runtime change detected; needs human or /explore agent validation. labels Jun 28, 2026
@lefarcen

Copy link
Copy Markdown
Contributor

🧪 This PR changes the copied Use Everywhere guide behavior, so it’ll need a manual QA pass before merge. Please hold off self-merging for now; we’ll loop QA in once it’s merge-ready (and after any design/product sign-off that applies).

@github-actions

github-actions Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Visual regression review

Head: 81bcd31 · Base: a915da2

0 changed · 50 unchanged · 0 new without baseline · 0 failed

Unchanged cases
Case Main PR Diff
visual-avatar-local-agent-list
173 px (0.01%)
main pr diff
visual-avatar-local-agent-list-panel
0 px (0.00%)
main pr diff
visual-avatar-menu
173 px (0.01%)
main pr diff
visual-avatar-menu-panel
0 px (0.00%)
main pr diff
visual-critical-settings
0 px (0.00%)
main pr diff
visual-critical-workspace
173 px (0.01%)
main pr diff
visual-critical-workspace-preview
0 px (0.00%)
main pr diff
visual-design-system-detail
0 px (0.00%)
main pr diff
visual-design-systems
0 px (0.00%)
main pr diff
visual-home
0 px (0.00%)
main pr diff
visual-home-catalog
0 px (0.00%)
main pr diff
visual-home-context-picker
11 px (0.00%)
main pr diff
visual-home-context-picker-popover
11 px (0.00%)
main pr diff
visual-home-plugin-filter
0 px (0.00%)
main pr diff
visual-home-plugin-use-staged
0 px (0.00%)
main pr diff
visual-home-plugin-use-with-query
0 px (0.00%)
main pr diff
visual-home-staged-attachment
0 px (0.00%)
main pr diff
visual-integrations
0 px (0.00%)
main pr diff
visual-integrations-mcp
0 px (0.00%)
main pr diff
visual-integrations-use-everywhere
158 px (0.01%)
main pr diff

Visual diff is advisory only and does not block merging.

@mrcfps mrcfps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YOMXXX Thanks for tightening the copied MCP guide — pulling the daemon-reported launch tuple into the handoff text is the right fix direction. I found one follow-up in the new async fetch path that can still copy the old PATH-based guide if the user clicks immediately.

🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos.

Comment thread apps/web/src/components/UseEverywhereModal.tsx
@YOMXXX
YOMXXX force-pushed the fix/issue-4852-mcp-guide-launcher branch from 0dd3c7f to 73f2d04 Compare June 29, 2026 00:57

@mrcfps mrcfps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YOMXXX Thanks for tightening the copied MCP guide — pulling the daemon-reported launch tuple into the handoff text is the right direction. I found one blocker before this is safe to ship for packaged Windows installs.

🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos.

Comment thread apps/web/src/components/use-everywhere/agent-guide.ts Outdated
@YOMXXX
YOMXXX force-pushed the fix/issue-4852-mcp-guide-launcher branch from 73f2d04 to c007ae0 Compare June 29, 2026 01:16

@mrcfps mrcfps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YOMXXX Thanks for tightening the copied MCP guide — pulling the daemon-reported launch tuple into the guide is the right fix direction. I found one follow-up in the same modal where the MCP snippet itself still stays on the generic PATH-based config.

🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos.

Comment thread apps/web/src/components/UseEverywhereModal.tsx
@YOMXXX
YOMXXX force-pushed the fix/issue-4852-mcp-guide-launcher branch from c007ae0 to 81bcd31 Compare June 29, 2026 02:14
@YOMXXX
YOMXXX requested a review from mrcfps June 29, 2026 02:19

@mrcfps mrcfps left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YOMXXX I re-reviewed the updated changed ranges and confirmed the copied guide plus the MCP-tab render/copy paths now all source the MCP JSON from /api/mcp/install-info, with regression tests covering the immediate-click race and the packaged-Windows launcher tuple. Thanks for pushing through the follow-ups here 🙏

🔁 Powered by Looper · runner=reviewer · agent=opencode · An autonomous AI dev team for your GitHub repos.

@lefarcen

lefarcen commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Hey @YOMXXX — quick status update from our side: the code-review loop is already in a good place, and the remaining step here is the manual QA pass that's queued for this PR.

Nothing new is needed from you right now. If you hit a blocker or want another look after a follow-up push, just drop a note here.

@AmyShang-alt AmyShang-alt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA 验收记录

验收范围:

  • Use Everywhere 的 agent guide / MCP snippet 在 install-info 成功和失败两条路径下的展示与复制行为。

已验证:

  • PR head: 81bcd31c8cf04a40fa25570efa7eb5274e2672c0
  • Targeted tests: pnpm --filter @open-design/web exec vitest run -c vitest.config.ts --maxWorkers=2 tests/components/use-everywhere-agent-guide.test.ts tests/components/use-everywhere-copy-guide.test.tsx,2 files / 14 tests passed。
  • Electron runtime: isolated worktree /Users/mac/open-design/pr-4865-electron, namespace pr4865, Use Everywhere -> MCP Server opened successfully.
  • Success path: /api/mcp/install-info returned the daemon launch tuple, and both rendered MCP snippet + copied guide/snippet used the absolute command, daemon args, and env instead of bare "command": "od".
  • Fallback path: mocked /api/mcp/install-info 404; UI did not crash and MCP snippet fell back to the od mcp --daemon-url ... guidance as expected.

未验证:

  • Real Windows packaged app + external MCP client launch was not run on Windows hardware.

风险/关注点:

  • Remaining platform risk is limited to true Windows packaged-client execution; the web/Electron copy/render behavior and fallback behavior are covered.

结论:

  • 验收通过。

@AmyShang-alt AmyShang-alt added validated Runtime change validated (via /explore Pass or manual QA). and removed needs-validation Runtime change detected; needs human or /explore agent validation. labels Jul 2, 2026
@AmyShang-alt
AmyShang-alt added this pull request to the merge queue Jul 2, 2026
Merged via the queue into nexu-io:main with commit 07a6dc6 Jul 2, 2026
25 checks passed
xxiaoxiong pushed a commit to xxiaoxiong/open-design that referenced this pull request Jul 9, 2026
xxiaoxiong pushed a commit to xxiaoxiong/open-design that referenced this pull request Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/medium Medium risk: regular code changes size/M PR changes 100-300 lines type/bugfix Bug fix validated Runtime change validated (via /explore Pass or manual QA).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Windows v0.12.0 packaged app: od command is missing, so MCP server cannot be started from the copied guide

4 participants