test(e2e): expand onboarding, AMR, automation, and home coverage - #4759
Conversation
lefarcen
added
risk/medium
|
@AmyShang-alt 这版描述主体已经够清楚了， 还差一块 |
mrcfps
left a comment
mrcfps
left a comment
There was a problem hiding this comment.
@AmyShang-alt I reviewed the changed e2e ranges across the AMR onboarding/logout coverage, Automations flows, Home creation/template/design-system coverage, project design-system picker coverage, and the small Playwright group helper updates. I did not find a concrete correctness, safety, or maintainability issue that needs action before merge.
I attempted local e2e typecheck and Playwright list validation, but this prepared worktree has no installed dependencies/Playwright binary, so those commands could not run locally; the live CI checks I inspected were passing except for the still-pending entry-settings job at review time. Thanks for the thorough coverage expansion here. 🙂
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.
Visual regression reviewHead: 0 changed · 50 unchanged · 0 new without baseline · 0 failed Unchanged cases
Visual diff is advisory only and does not block merging. |
Generated-By: looper 0.9.11 (runner=fixer, agent=codex)
mrcfps
left a comment
mrcfps
left a comment
There was a problem hiding this comment.
@AmyShang-alt I reviewed the changed e2e ranges across the onboarding AMR/local/BYOK coverage, AMR logout recovery, Automations create/edit/run flows, Home template/design-system/blank-project coverage, project design-system picker cases, and the small Playwright group helper updates. I did not find a concrete correctness, safety, or maintainability issue that needs action before merge.
Local validation in this prepared worktree could not run because dependencies are not installed (node_modules and Playwright are missing), but I checked the live PR status and the relevant CI jobs are passing, including static, workspace, e2e Vitest, UI P0 groups, and visual suites. Thanks for the careful coverage expansion here. 🙂
mrcfps
left a comment
mrcfps
left a comment
There was a problem hiding this comment.
@AmyShang-alt I reviewed the changed ranges across the onboarding AMR/local/BYOK coverage, AMR logout recovery, Automations create/edit/reuse/run flows, Home template/design-system/blank-project coverage, project design-system picker cases, the Playwright group helper updates, and the onboarding language-menu CSS fix. I did not find a concrete correctness, safety, test-quality, or maintainability issue that needs action before merge.
I could not run local validation in this prepared worktree because dependencies are not installed (node_modules is missing), but I checked the live PR checks for this head and the relevant static, workspace, e2e Vitest, UI P0, and visual jobs are passing. Thanks for the thorough coverage expansion and the follow-up toolbar fix. 🙂
a5743a1 to
7126fbf
Compare
|
Not stuck — the current head already has maintainer + design approval. The remaining blocker is that the branch is now dirty against |
mrcfps
left a comment
mrcfps
left a comment
There was a problem hiding this comment.
@AmyShang-alt I reviewed the changed e2e ranges across the AMR onboarding/logout coverage, Automations create/edit/run/template/proposal flows, Home creation and template/design-system coverage, project design-system picker cases, and the small Playwright group helper updates. I did not find a concrete correctness, safety, test-quality, or maintainability issue that needs action before merge.
I could not run local validation in this prepared worktree because dependencies are not installed (node_modules is missing), but I checked the live PR checks for this head and the relevant static, workspace, e2e Vitest, UI P0, and visual jobs are passing. Thanks for the thorough coverage expansion here. 🙂
…u-io#4759) * test(e2e): cover onboarding and automation flows * test(e2e): stabilize AMR project runtime P0 group * test(e2e): cover updated home creation surface * test(e2e): align onboarding coverage with build step Generated-By: looper 0.9.11 (runner=fixer, agent=codex)
…u-io#4759) * test(e2e): cover onboarding and automation flows * test(e2e): stabilize AMR project runtime P0 group * test(e2e): cover updated home creation surface * test(e2e): align onboarding coverage with build step Generated-By: looper 0.9.11 (runner=fixer, agent=codex)
3 participants
Summary
Verification
pnpm install --frozen-lockfilepnpm --dir e2e exec playwright test -c playwright.config.ts ui/home-hero-rail.test.ts ui/entry-chrome-flows.test.ts --grep "empty home composer|home design-system picker|template carousel scrolls|template reveal opens from wheel|blank project entry surfaces|template picker supports|zh-CN home smoke|home hero exposes the template picker|home template picker selects|first-run home keeps community templates collapsed|blank project entry creates|entry chrome exposes the primary home creation surface|entry top navigation matches|home view exposes the redesigned hero" --reporter=listpnpm --dir e2e exec playwright test -c playwright.config.ts ui/amr-onboarding.test.ts ui/automations-page.test.ts ui/project-management-flows.test.ts ui/amr-logout-requires-relogin.test.ts ui/entry-chrome-flows.test.ts ui/home-hero-rail.test.ts --listNotes
This replaces #4745 with a clean branch based on the latest
origin/main. The new PR only contains the target E2E coverage commits, avoiding the old branch's accumulated merge history.