Skip to content

[codex] Keep question forms editable after banner reopen#4120

Merged
Siri-Ray merged 1 commit into
release/v0.10.0from
codex/question-form-banner-editable
Jun 11, 2026
Merged

[codex] Keep question forms editable after banner reopen#4120
Siri-Ray merged 1 commit into
release/v0.10.0from
codex/question-form-banner-editable

Conversation

@Siri-Ray

Copy link
Copy Markdown
Contributor

Why

While testing the discovery question form, clicking the chat-side Questions banner after the form had already auto-opened moved the right-hand Questions panel into a locked state. The form still represented the latest unanswered assistant turn, so users should be able to keep selecting chips and typing answers after reopening it from the banner.

Root cause: the banner path always pinned a manual question-form request, and ProjectView treated all manual requests as historical read-only forms.

What users will see

Users can click the left chat Questions banner for the current unanswered form and the right Questions panel remains editable. Historical answered forms still reopen as read-only answered previews.

Surface area

  • UI — new page / dialog / panel / menu item / setting / empty state in apps/web or apps/desktop (including Electron menu bar)
  • Keyboard shortcut — new or changed
  • CLI / env var — new od subcommand or flag, new tools-dev / tools-pack / tools-pr flag, or new OD_* env var
  • API / contract — new /api/* endpoint, new SSE event, or changed shape in packages/contracts
  • Extension point — new entry under skills/, design-systems/, design-templates/, or craft/, or change to the skills protocol
  • i18n keys — added new translation keys (see TRANSLATIONS.md for the locale workflow)
  • New top-level dependency — adding any new entry to the root package.json (dependencies or devDependencies); workspace-package package.json files are out of scope. Include a paragraph on what we get vs. what bytes we ship (see CONTRIBUTING.md → Code style)
  • Default behavior change — changes what existing users experience without opting in (default model, default setting, file/SQLite schema, auto-network on startup, auto-install)
  • None — internal refactor, docs, tests, or translation update only

Screenshots

Not attached; this is an interaction-state bug on an existing form surface. The regression is covered by the component test below.

Bug fix verification

  • Test path that reproduces the bug: apps/web/tests/components/ProjectView.deleteConversation.test.tsx
  • Did the test go red on main and green on this branch? yes. The new test failed before the fix with questionFormInteractive becoming false, then passed after the fix.

Validation

  • pnpm install
  • pnpm --filter @open-design/web typecheck
  • pnpm exec vitest run -c vitest.config.ts tests/components/ProjectView.deleteConversation.test.tsx from apps/web
  • pnpm guard
  • pnpm typecheck

@github-actions

Copy link
Copy Markdown
Contributor

Visual regression review

Head: fbe5512 · Base: 9bf5ba3

Some cases used the nearest available ancestor baseline instead of the exact base SHA.

9 changed · 26 unchanged · 0 missing baseline · 0 failed

Changed cases

Case Main PR Diff
visual-avatar-menu
baseline 1 commit(s) behind
main pr diff
visual-home-plugin-use-with-query
baseline 1 commit(s) behind
main pr diff
visual-new-project-modal
baseline 1 commit(s) behind
main pr diff
visual-plugin-details
baseline 1 commit(s) behind
main pr diff
visual-settings-byok
baseline 1 commit(s) behind
main pr diff
visual-settings-byok-model-dropdown
baseline 1 commit(s) behind
main pr diff
visual-settings-execution
baseline 1 commit(s) behind
main pr diff
visual-settings-local-cli
baseline 1 commit(s) behind
main pr diff
visual-workspace-staged-contexts
baseline 1 commit(s) behind
main pr diff
Unchanged cases
Case Main PR Diff
visual-avatar-local-agent-list
baseline 1 commit(s) behind
main pr diff
visual-design-system-detail
baseline 1 commit(s) behind
main pr diff
visual-design-systems
baseline 1 commit(s) behind
main pr diff
visual-home
baseline 1 commit(s) behind
main pr diff
visual-home-catalog
baseline 1 commit(s) behind
main pr diff
visual-home-context-picker
baseline 1 commit(s) behind
main pr diff
visual-home-plugin-filter
baseline 1 commit(s) behind
main pr diff
visual-home-plugin-use-staged
baseline 1 commit(s) behind
main pr diff
visual-home-staged-attachment
baseline 1 commit(s) behind
main pr diff
visual-integrations
baseline 1 commit(s) behind
main pr diff
visual-integrations-mcp
baseline 1 commit(s) behind
main pr diff
visual-integrations-use-everywhere
baseline 1 commit(s) behind
main pr diff
visual-onboarding-runtime
baseline 1 commit(s) behind
main pr diff
visual-plugin-share-menu
baseline 1 commit(s) behind
main pr diff
visual-plugins
baseline 1 commit(s) behind
main pr diff
visual-project-avatar-model-dropdown
baseline 1 commit(s) behind
main pr diff
visual-project-workspace
baseline 1 commit(s) behind
main pr diff
visual-projects
baseline 1 commit(s) behind
main pr diff
visual-projects-kanban
baseline 1 commit(s) behind
main pr diff
visual-settings-byok-openai
baseline 1 commit(s) behind
main pr diff

Visual diff is advisory only and does not block merging.

@Siri-Ray Siri-Ray requested a review from nettee June 11, 2026 03:40
@lefarcen lefarcen added size/M PR changes 100-300 lines risk/medium Medium risk: regular code changes type/bugfix Bug fix labels Jun 11, 2026

@nettee nettee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Siri-Ray I reviewed the changed ranges in ProjectView and the companion regression test. The openQuestionsTab branch now correctly keeps the current unanswered form on the live editable path while still preserving the manual read-only behavior for historical reopen cases, and the added test covers the banner-reopen regression directly. I wasn't able to rerun the targeted Vitest file in this worktree because node_modules are not installed here, but I didn't find any actionable correctness or maintainability issues in the scoped diff. Nice, focused fix.

🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.

@Siri-Ray Siri-Ray merged commit 4978e4c into release/v0.10.0 Jun 11, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/medium Medium risk: regular code changes size/M PR changes 100-300 lines type/bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants