[codex] Keep question forms editable after banner reopen#4120
Merged
Conversation
Contributor
nettee
approved these changes
Jun 11, 2026
nettee
left a comment
Contributor
There was a problem hiding this comment.
@Siri-Ray I reviewed the changed ranges in ProjectView and the companion regression test. The openQuestionsTab branch now correctly keeps the current unanswered form on the live editable path while still preserving the manual read-only behavior for historical reopen cases, and the added test covers the banner-reopen regression directly. I wasn't able to rerun the targeted Vitest file in this worktree because node_modules are not installed here, but I didn't find any actionable correctness or maintainability issues in the scoped diff. Nice, focused fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.














































































Why
While testing the discovery question form, clicking the chat-side Questions banner after the form had already auto-opened moved the right-hand Questions panel into a locked state. The form still represented the latest unanswered assistant turn, so users should be able to keep selecting chips and typing answers after reopening it from the banner.
Root cause: the banner path always pinned a manual question-form request, and
ProjectViewtreated all manual requests as historical read-only forms.What users will see
Users can click the left chat Questions banner for the current unanswered form and the right Questions panel remains editable. Historical answered forms still reopen as read-only answered previews.
Surface area
apps/weborapps/desktop(including Electron menu bar)odsubcommand or flag, newtools-dev/tools-pack/tools-prflag, or newOD_*env var/api/*endpoint, new SSE event, or changed shape inpackages/contractsskills/,design-systems/,design-templates/, orcraft/, or change to the skills protocolTRANSLATIONS.mdfor the locale workflow)package.json(dependenciesordevDependencies); workspace-packagepackage.jsonfiles are out of scope. Include a paragraph on what we get vs. what bytes we ship (seeCONTRIBUTING.md→ Code style)Screenshots
Not attached; this is an interaction-state bug on an existing form surface. The regression is covered by the component test below.
Bug fix verification
apps/web/tests/components/ProjectView.deleteConversation.test.tsxmainand green on this branch? yes. The new test failed before the fix withquestionFormInteractivebecomingfalse, then passed after the fix.Validation
pnpm installpnpm --filter @open-design/web typecheckpnpm exec vitest run -c vitest.config.ts tests/components/ProjectView.deleteConversation.test.tsxfromapps/webpnpm guardpnpm typecheck