feat(web): split onboarding newsletter into its own third step#4106
Conversation
|
Heads-up: PR #3651 (@Sid-Qin, "Make onboarding a focused setup flow") is also open and touches all four files this PR modifies — |
nettee
left a comment
There was a problem hiding this comment.
I found one non-blocking analytics regression in the new onboarding step split: the About-you snapshot is now tied to a specific navigation action instead of the overall completion path.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.
Siri-Ray
left a comment
There was a problem hiding this comment.
@elihahah666 thanks for splitting the newsletter capture into its own focused onboarding step. I found one merge-blocking issue: the PR adds the third step in the app and unit coverage, but the critical Playwright onboarding flows still exercise the old two-step path and are failing in CI.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.
nettee
left a comment
There was a problem hiding this comment.
One non-blocking item remains in the current head: the e2e follow-up looks addressed, but the About-you analytics snapshot is still tied to one navigation path instead of the overall completion path.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.…tion path The newsletter step is now its own (final) step with a clickable stepper and Back button. Emitting the about_you_submit survey snapshot when the user leaves the About-you step double-fired on Back-then-Continue and fired zero times on a forward stepper jump. Move it onto the completion path, stamp it with fixed About-you coordinates (it describes the About-you submission regardless of which step finishes), and guard it with a per-session ref so it is exactly-once. Adds regression tests for the stepper-jump and Back-then-Continue flows.
|
Thanks for the review — both points addressed: @Siri-Ray (e2e P0 gate): Fixed in 09b1b96. @nettee (about_you_submit no longer exactly-once): Fixed in a361b3a. Moved the snapshot off the "leaving About-you" path back onto the completion path, stamped it with fixed About-you coordinates (area/step) since it describes the About-you submission regardless of which step finishes, and guarded it with a per-session Re-requesting review. |

















































































Why
onboarding 第二步「了解你」(About you) 同时塞了身份/规模/用途/来源四个调研下拉 和 newsletter 邮箱订阅,一屏里混了两类不相干的诉求,邮箱框被挤在问卷底部容易被忽略。把订阅单拎成独立的第三步,让 About-you 只做用户画像问卷、订阅有自己的落地步骤,转化路径更清楚。i18n key 和埋点枚举此前已为「第三步」预留,这次只是把 UI 接上。
What users will see
首次启动的 onboarding 引导从 2 步变 3 步:连接 → 了解你 → 获取最新动态。
行为不变:邮箱仍在最后一步点「完成设置」时提交;留空则跳过;只上报 opt-in 布尔,不上报邮箱地址本身。
Surface area
apps/web)settings.onboardingStepNewsletter(19 个 locale)Screenshots
第二步「了解你」(邮箱框已移出):四个调研下拉 + 上一步/继续。
第三步「获取最新动态」:独立页面,占满宽度的邮箱框 + 上一步/完成设置;顶部三格步骤条第 3 格高亮。
(本地 headless 截图已核对:第三步邮箱框宽度 860px = 面板宽度,和第二步下拉框对齐。)
Bug fix verification
Validation
pnpm guard✅pnpm typecheck✅pnpm --filter @open-design/web test✅(324 文件 / 3184 用例通过,含更新后的EntryShell.onboarding.test.tsx)pnpm tools-dev run web起服务,headless 浏览器走完三步逐屏核对