fix(daemon): map Claude Not logged in output to /login guidance (#1928)#3050
fix(daemon): map Claude Not logged in output to /login guidance (#1928)#3050leno23 wants to merge 1 commit into
Conversation
…-io#1928) Treat Claude Code stdout like "Not logged in · Please run /login." as an auth failure in diagnoseClaudeCliFailure so connection tests and chat runs surface actionable login guidance instead of raw CLI text.
lefarcen
added
size/XS
lefarcen
left a comment
lefarcen
left a comment
There was a problem hiding this comment.
Hi @leno23 — thanks for tying this directly back to the Claude login report in #1928. The summary and validation are clear; one small PR-body cleanup before pool review: could you add the checklist-style ## Surface area section and tick the relevant box for this user-visible daemon diagnostic change? I’d expect Default behavior change here, since the connection-test failure now maps to guidance instead of showing raw CLI output.
Related: #1928 is the reporter thread this PR is addressing, and I added a short pointer there so the issue stays connected while review runs.
lefarcen
left a comment
lefarcen
left a comment
There was a problem hiding this comment.
Hi @leno23 — thanks for tying this directly back to the Claude login report in #1928. The summary and validation are clear; one small PR-body cleanup before pool review: could you add the checklist-style ## Surface area section and tick the relevant box for this user-visible daemon diagnostic change? I’d expect Default behavior change here, since the connection-test failure now maps to guidance instead of showing raw CLI output.
Related: #1928 is the reporter thread this PR is addressing, and I added a short pointer there so the issue stays connected while review runs.
mrcfps
left a comment
mrcfps
left a comment
There was a problem hiding this comment.
@leno23 I reviewed the daemon diagnostic change and the added regression coverage for the Claude Not logged in · Please run /login. output. The auth classification stays narrowly scoped to Claude failures, and pnpm test tests/claude-diagnostics.test.ts passes locally for the updated fixture set. Thanks for tightening up this login guidance path. 🙌
3 participants
Refs #1928
Summary
When Claude Code exits during a connection test with stdout like
Not logged in · Please run /login., Open Design now classifies it as an auth failure and returns the existing/login+CLAUDE_CONFIG_DIRguidance instead of surfacing the raw CLI text.Surface area
apps/daemon/src/claude-diagnostics.ts— recognizenot logged in/please run /loginoutputapps/daemon/tests/claude-diagnostics.test.ts— regression test for the reported message shapeValidation
cd apps/daemon && pnpm test tests/claude-diagnostics.test.tsMade with Cursor