fix(web): add New project CTA to projects empty state (#2978)#3043
fix(web): add New project CTA to projects empty state (#2978)#3043leno23 wants to merge 1 commit into
Conversation
When the projects page has no items, show a primary action in the main content area instead of only pointing users to the sidebar. Fixes nexu-io#2978
lefarcen
added
size/M
Visual regression reviewHead: 1 changed · 16 unchanged · 0 missing baseline · 0 failed Changed cases
Unchanged cases
Visual diff is advisory only and does not block merging. |
lefarcen
left a comment
lefarcen
left a comment
There was a problem hiding this comment.
Hey @leno23, thanks for picking up the #2978 empty-state flow — the summary makes the CTA and modal path clear. One PR-body detail before pool review scopes this: could you add the template ## Surface area checklist and tick the user-visible boxes here (at least UI, and likely i18n since the empty-state copy changes)? The existing file list is helpful; the checklist makes release/review impact easier to scan.
Siri-Ray
left a comment
Siri-Ray
left a comment
There was a problem hiding this comment.
@leno23 thanks for tightening the empty-project flow and wiring the CTA through the existing modal path. I found one merge-safe i18n consistency issue to address so the new guidance lands the same way outside the updated locales.
🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.| 'designs.filterAria': 'Filter projects', | ||
| 'designs.searchPlaceholder': 'Search…', | ||
| 'designs.emptyNoProjects': 'No projects yet. Create one on the left.', | ||
| 'designs.emptyNoProjects': 'Create your first project to start designing.', |
There was a problem hiding this comment.
This copy update only changes designs.emptyNoProjects for English, zh-CN, and zh-TW, but the same key in the other locale files still tells users to create the project from the left/sidebar. That means users on locales like fr, de, es-ES, ja, etc. still see the stale instruction even though this PR adds the primary CTA in the main empty state. Please update the remaining locale values for designs.emptyNoProjects to remove the left/sidebar reference as well, using the English text as the source if localized wording is not available yet.
|
Hey @leno23, quick coordination note: #3060 is now also open for #2978. Both PRs touch |
3 participants
/claim #2978
Summary
openNewProject()modal flow fromEntryShell.Surface area
apps/web/src/components/DesignsTab.tsxapps/web/src/components/EntryShell.tsxapps/web/src/styles/workspace/connectors.cssapps/web/src/i18n/locales/en.ts,zh-CN.ts,zh-TW.tsapps/web/tests/components/DesignsTab.empty-state.test.tsxValidation
cd apps/web && pnpm test tests/components/DesignsTab.empty-state.test.tsxMade with Cursor