fix(web): expose manual edit undo/redo and save confirmation by leno23 · Pull Request #3034 · nexu-io/open-design

leno23 · 2026-05-26T15:32:56Z

Also helps #2905 — the edit panel now shows transient Saved ✓ / Saving… feedback after persisted manual edits (including deletes), even though the legacy HTML tab UI is no longer present.

Summary

Manual edit history (undoManualEdit / redoManualEdit) already worked in FileViewer, but ManualEditPanel never rendered controls or keyboard shortcuts, so deletes felt irreversible.

Surface area

apps/web/src/components/ManualEditPanel.tsx — Undo/Redo buttons, Cmd/Ctrl+Z shortcuts, saved status line.
apps/web/src/components/FileViewer.tsx — track manualEditSavedAt after successful writes/undo/redo.
apps/web/src/styles/viewer/memory.css — titlebar status styling.
Tests in ManualEditPanel.test.tsx and FileViewer.manual-edit-history.test.tsx.

Validation

cd apps/web && pnpm test tests/components/ManualEditPanel.test.tsx tests/components/FileViewer.manual-edit-history.test.tsx — 27 passed.

Made with Cursor

…#2866) Wire the existing history callbacks into the edit panel with Undo/Redo buttons, keyboard shortcuts, and a transient Saved status after writes.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8281a87753

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-26T15:36:06Z

+      const mod = event.metaKey || event.ctrlKey;
+      if (!mod || event.altKey) return;
+      if (event.key.toLowerCase() === 'z' && !event.shiftKey && canUndo) {
+        event.preventDefault();
+        onUndo();


Skip document undo hotkeys when focus is in editable fields

The new global keydown listener handles Cmd/Ctrl+Z without checking whether the focused element is an input, textarea, or contentEditable, so once canUndo is true, pressing undo while typing in any manual-edit form control triggers onUndo() and writes an older full document to disk instead of undoing text in that field. This is a destructive behavior change for normal editing workflows; the shortcut handler should bail out for editable targets (and typically for already-handled events).

Useful? React with 👍 / 👎.

github-actions · 2026-05-26T15:37:36Z

Visual regression review

Head: 8281a87 · Base: 1d72914

0 changed · 17 unchanged · 0 missing baseline · 0 failed

Unchanged cases

Case	Main	PR	Diff
visual-avatar-menu
visual-design-systems
visual-home
visual-home-catalog
visual-home-context-picker
visual-home-plugin-filter
visual-integrations
visual-integrations-use-everywhere
visual-new-project-modal
visual-plugin-details
visual-plugins
visual-projects
visual-projects-kanban
visual-settings-byok
visual-settings-execution
visual-tasks
visual-topbar-execution-switcher

Visual diff is advisory only and does not block merging.

lefarcen

Hi @leno23! Thanks for tying #2866 to the manual-edit history path — the Summary and Validation make the intent clear. One PR-body thing before pool review: could you update ## Surface area to use the checklist and tick UI? This touches visible ManualEditPanel controls/status, so the checklist helps reviewers and release verification scope it quickly.

Related: #2925 by @xxiaoxiong is also open in this area and overlaps on FileViewer.tsx, ManualEditPanel.tsx, and memory.css for #2905 save-confirmation feedback. You two may want to compare approaches; the maintainer team will pick what lands.

lefarcen

Hi @leno23! Thanks for tying #2866 to the manual-edit history path — the Summary and Validation make the intent clear. One PR-body thing before pool review: could you update ## Surface area to use the checklist and tick UI? This touches visible ManualEditPanel controls/status, so the checklist helps reviewers and release verification scope it quickly.

Related: #2925 by @xxiaoxiong is also open in this area and overlaps on FileViewer.tsx, ManualEditPanel.tsx, and memory.css for #2905 save-confirmation feedback. You two may want to compare approaches; the maintainer team will pick what lands.

lefarcen

Hi @leno23! Thanks for tying #2866 to the manual-edit history path — the Summary and Validation make the intent clear. One PR-body thing before pool review: could you update ## Surface area to use the checklist and tick UI? This touches visible ManualEditPanel controls/status, so the checklist helps reviewers and release verification scope it quickly.

Related: #2925 by @xxiaoxiong is also open in this area and overlaps on FileViewer.tsx, ManualEditPanel.tsx, and memory.css for #2905 save-confirmation feedback. You two may want to compare approaches; the maintainer team will pick what lands.

PerishCode

@leno23 — thanks for closing the loop on #2866 with the undo/redo controls, keyboard shortcuts, and the transient Saved ✓ confirmation in ManualEditPanel. The tests cover both the panel-level wiring and the FileViewer history regression (delete → undo restores the element), which is exactly the right shape for a bugfix PR.

One non-blocking inline finding (i18n consistency for the new status label).

Unrelated to this review's inline finding, the existing unresolved Codex thread on the global keydown listener is worth addressing before merge: ManualEditPanel contains several <input> elements (UnitRow, ColorRow, QuadCell), so Cmd/Ctrl+Z while focus is in one of those inputs will now hit the window-level handler instead of native input undo, overwriting the file with the previous persisted snapshot. A guard such as if (event.target instanceof HTMLInputElement || event.target instanceof HTMLTextAreaElement || (event.target as HTMLElement)?.isContentEditable) return; would resolve it.

_{🔁 Powered by Looper · runner=reviewer · agent=claude-code · An autonomous AI dev team for your GitHub repos.}

PerishCode · 2026-05-26T15:44:03Z

+            {busy ? (
+              <em className="manual-edit-status" data-testid="manual-edit-status">
+                Saving…
+              </em>
+            ) : showSaved ? (
+              <em className="manual-edit-status" data-testid="manual-edit-status">
+                Saved ✓
+              </em>
+            ) : null}


The two new status labels are hardcoded English: Saving… (line 130) and Saved ✓ (line 134). The surrounding titlebar text was migrated to t('manualEdit.title') in this same PR, and the new undo/redo buttons below use t('manualEdit.undo') / t('manualEdit.redo'), so a non-English locale (e.g. zh-CN, ja, fr) will render this titlebar as a mix of localized + raw English, which is jarring and breaks the i18n convention the rest of this PR follows.

Why it matters: per the root AGENTS.md i18n keys section, user-visible strings must be defined as typed keys in apps/web/src/i18n/types.ts and populated for all 18 locale files. The change to t('manualEdit.title') clearly intends to honor that contract; the new status strings sidestep it for the same surface in the same patch.

Suggested change: add two new keys to apps/web/src/i18n/types.ts (for example 'manualEdit.savingStatus': string and 'manualEdit.savedStatus': string), populate them in every file under apps/web/src/i18n/locales/ (the English values can stay Saving… / Saved ✓ — translators can localize later), and replace these two literals with t('manualEdit.savingStatus') and t('manualEdit.savedStatus'). Keep the existing <em className="manual-edit-status" data-testid="manual-edit-status"> wrapper and the visual treatment unchanged so the test selectors still match.

_{🔁 Powered by Looper · runner=reviewer · agent=claude-code · An autonomous AI dev team for your GitHub repos.}

lefarcen · 2026-05-26T17:19:56Z

Heads-up: PR #3055 is also open in this manual-edit feedback area. Both PRs touch apps/web/src/components/FileViewer.tsx; #3034 covers undo/redo + save confirmation more broadly, while #3055 is a narrower Apply HTML success toast for #2905.

You and @DonQuilatte may want to coordinate so effort does not get duplicated; maintainers will pick the final shape.

fix(web): expose manual edit undo/redo and save confirmation (nexu-io…

8281a87

…#2866) Wire the existing history callbacks into the edit panel with Undo/Redo buttons, keyboard shortcuts, and a transient Saved status after writes.

chatgpt-codex-connector Bot reviewed May 26, 2026

View reviewed changes

lefarcen requested a review from PerishCode May 26, 2026 15:39

lefarcen added size/M PR changes 100-300 lines risk/medium Medium risk: regular code changes type/bugfix Bug fix labels May 26, 2026

This was referenced May 26, 2026

Bug Report: Deleted elements cannot be undone in Edit mode #2866

Open

Show confirmation feedback after successful HTML edits in the editor #2905

Open

lefarcen reviewed May 26, 2026

View reviewed changes

lefarcen mentioned this pull request May 26, 2026

feat: show success feedback after HTML edits in manual editor #2925

Open

4 tasks

PerishCode reviewed May 26, 2026

View reviewed changes

lefarcen mentioned this pull request May 26, 2026

feat(web): show success toast after Apply HTML edit (#2905) #3055

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(web): expose manual edit undo/redo and save confirmation#3034

fix(web): expose manual edit undo/redo and save confirmation#3034
leno23 wants to merge 1 commit into
nexu-io:mainfrom
leno23:fix/manual-edit-undo-ui-2866

leno23 commented May 26, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 26, 2026

Uh oh!

github-actions Bot commented May 26, 2026

Uh oh!

lefarcen left a comment

Uh oh!

lefarcen left a comment

Uh oh!

lefarcen left a comment

Uh oh!

PerishCode left a comment

Uh oh!

PerishCode May 26, 2026

Uh oh!

lefarcen commented May 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

leno23 commented May 26, 2026

Summary

Surface area

Validation

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 26, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 26, 2026

Visual regression review

Uh oh!

lefarcen left a comment

Choose a reason for hiding this comment

Uh oh!

lefarcen left a comment

Choose a reason for hiding this comment

Uh oh!

lefarcen left a comment

Choose a reason for hiding this comment

Uh oh!

PerishCode left a comment

Choose a reason for hiding this comment

Uh oh!

PerishCode May 26, 2026

Choose a reason for hiding this comment

Uh oh!

lefarcen commented May 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants