Skip to content

fix(web): resolve skill vs type-chip routing conflicts#3031

Open
leno23 wants to merge 1 commit into
nexu-io:mainfrom
leno23:fix/home-routing-skill-plugin-conflict-2972
Open

fix(web): resolve skill vs type-chip routing conflicts#3031
leno23 wants to merge 1 commit into
nexu-io:mainfrom
leno23:fix/home-routing-skill-plugin-conflict-2972

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented May 26, 2026

Fixes #2972

Summary

Home hero could keep both an active scenario type chip (plugin) and an @skill selection at once, then submit with conflicting pluginId + skillId routing. Picking one source now clears the other, and submit omits skillId whenever a scenario plugin is active.

Surface area

  • apps/web/src/components/HomeView.tsx — mutual exclusion in usePlugin / useSkill; guard skillId on submit.
  • apps/web/tests/components/HomeView.context-picker.test.tsx — regression tests for chip→skill and skill→chip flows.

Validation

  • cd apps/web && pnpm test tests/components/HomeView.context-picker.test.tsx — 5 passed.

Made with Cursor

Clear the opposing selection when the user picks a skill or scenario
chip, and omit skillId when a scenario plugin is active on submit.
@lefarcen lefarcen requested a review from Siri-Ray May 26, 2026 15:27
@lefarcen lefarcen added size/M PR changes 100-300 lines risk/medium Medium risk: regular code changes type/bugfix Bug fix labels May 26, 2026
Copy link
Copy Markdown
Contributor

@lefarcen lefarcen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leno23, thanks for jumping on the #2972 routing conflict so quickly — the Summary and Validation make the fix direction easy to follow.

One small PR-description housekeeping ask before pool review: could you update the ## Surface area section to use the repo's checklist and tick the affected surface (this looks like UI/default routing behavior), rather than only listing files? That helps reviewers and release verification see the user-facing surface at a glance.

@github-actions
Copy link
Copy Markdown
Contributor

Visual regression review

Head: b0c4a03 · Base: 1d72914

0 changed · 17 unchanged · 0 missing baseline · 0 failed

Unchanged cases
Case Main PR Diff
visual-avatar-menu main pr diff
visual-design-systems main pr diff
visual-home main pr diff
visual-home-catalog main pr diff
visual-home-context-picker main pr diff
visual-home-plugin-filter main pr diff
visual-integrations main pr diff
visual-integrations-use-everywhere main pr diff
visual-new-project-modal main pr diff
visual-plugin-details main pr diff
visual-plugins main pr diff
visual-projects main pr diff
visual-projects-kanban main pr diff
visual-settings-byok main pr diff
visual-settings-execution main pr diff
visual-tasks main pr diff
visual-topbar-execution-switcher main pr diff

Visual diff is advisory only and does not block merging.

Copy link
Copy Markdown
Contributor

@Siri-Ray Siri-Ray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leno23 I reviewed the HomeView routing changes and the added context-picker regression coverage. The updated selection handlers now clear the opposing route source, submit derives skillId from the active scenario state, and the new tests cover both chip-to-skill and skill-to-chip flows. CI is green for the relevant web/workspace checks; I could not rerun the focused Vitest locally because this Looper worktree has no node_modules, but the live Web workspace tests passed. Thanks for tightening this routing path and adding focused regression coverage.

🔁 Powered by Looper · runner=reviewer · agent=codex · An autonomous AI dev team for your GitHub repos.

@lefarcen
Copy link
Copy Markdown
Contributor

Reviewer approval and CI are green — flagged for the maintainer team to make the merge call. Thanks @leno23 for the fix and @Siri-Ray for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk/medium Medium risk: regular code changes size/M PR changes 100-300 lines type/bugfix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prompt intent can conflict with card selection and create inconsistent task routing

3 participants