feat(sms-authenticator) add option to specify api secret header - #395
Closed
petrsni wants to merge 2 commits into
Closed
feat(sms-authenticator) add option to specify api secret header#395petrsni wants to merge 2 commits into
petrsni wants to merge 2 commits into
Conversation
Collaborator
|
Thanks! Should be solved here similar with the attribute option |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
apiTokenHeaderFieldconfiguration option to the SMS authenticator, allowing to specify which HTTP header is used to transmit the API secret instead of always defaulting toAuthorization.Motivation
access-token,api-key) instead ofAuthorizationChanges
SmsAuthenticatorFactory.javaapiTokenHeaderFieldconfig property (type String, defaults toAuthorization)ApiSmsService.javaapiTokenHeaderFieldfrom config in the constructor (defaults toAuthorization)apiTokenHeaderFieldinstead of the hardcoded string"Authorization"when setting the auth header for both token-based and Basic Auth requestsBackward Compatibility
Authorization, so all existing configurations continue to work unchanged without any migration