fix: change default install dir from ./bin to $HOME/.local/bin#6107
Open
AruneshDwivedi wants to merge 1 commit into
Open
fix: change default install dir from ./bin to $HOME/.local/bin#6107AruneshDwivedi wants to merge 1 commit into
AruneshDwivedi wants to merge 1 commit into
Conversation
…l/bin The install script was defaulting to ./bin (relative to current working directory) instead of a proper user bin directory. This caused act to be installed in whatever directory the user happened to be in when running the install script, making it unfindable. Fixes nektos#2519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fix for the install script. Right now when you run the curl install it drops the binary into ./bin relative to wherever you happened to be sitting. So like if you ran it from your home dir, act ends up in ~/bin which probably isn't in your PATH.
Changed the default to $HOME/.local/bin which is at least a standard location.
Fixes #2519