Include missing files in datastack; object-oriented datastack archiving#2594
Draft
emlys wants to merge 7 commits into
Draft
Include missing files in datastack; object-oriented datastack archiving#2594emlys wants to merge 7 commits into
emlys wants to merge 7 commits into
Conversation
emlys
commented
Jun 9, 2026
| class IOModel(ImmutableBaseModel): | ||
| """Base class for both `Input` and `Output`.""" | ||
|
|
||
| id: str |
Member
Author
There was a problem hiding this comment.
Moved these attributes into the base class because they are shared between Input and Output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes #2589 by updating the datastack-archiving logic to include any file-based inputs referenced in a CSV, not just spatial inputs.
I also decided to refactor
build_datastack_archiveinto an object-oriented design, where eachInputtype owns its method for archiving a value. I think this is overall clearer and more extensible than the previous design. In the case of the HRA criteria table, the custom archiving logic now lives in aHRACriteriaTableInputsubclass.Checklist