Skip to content

fix: input range margin on focus#1288

Merged
ronald-urbina merged 3 commits into
muxinc:mainfrom
ronald-urbina:fix/range-inputs-focus-unexpected-margin
Apr 24, 2026
Merged

fix: input range margin on focus#1288
ronald-urbina merged 3 commits into
muxinc:mainfrom
ronald-urbina:fix/range-inputs-focus-unexpected-margin

Conversation

@ronald-urbina

@ronald-urbina ronald-urbina commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Removes the negative bottom offset (-7px / -5px) from the #range hit zone that was causing a layout shift when the range control received focus (issue #1254).

Also fixes invalid CSS syntax in the height property by wrapping arithmetic expressions in calc() (max(100% + 7px) → max(calc(100% + 7px))).

Fixes 1254


Note

Low Risk
Low risk CSS-only change; may slightly alter the time range hit/hover area sizing/position across browsers.

Overview
Prevents layout shift when the range input receives focus by removing the negative bottom offset on the #range hit/hover zone and normalizing its default height in both base and @media (hover: hover) styles.

Reviewed by Cursor Bugbot for commit 51b2ed5. Bugbot is set up for automated code reviews on this repo. Configure here.

@ronald-urbina ronald-urbina requested review from a team and heff as code owners April 20, 2026 18:41
@vercel

vercel Bot commented Apr 20, 2026

Copy link
Copy Markdown

@ronald-urbina is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io

snyk-io Bot commented Apr 20, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov

codecov Bot commented Apr 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.55%. Comparing base (3ea80df) to head (51b2ed5).
⚠️ Report is 301 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1288      +/-   ##
==========================================
- Coverage   78.55%   73.55%   -5.00%     
==========================================
  Files          59       56       -3     
  Lines       11080    13884    +2804     
  Branches        0      783     +783     
==========================================
+ Hits         8704    10213    +1509     
- Misses       2376     3638    +1262     
- Partials        0       33      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/js/media-chrome-range.ts Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bca7a00. Configure here.

Comment thread src/js/media-chrome-range.ts Outdated
@R-Delfino95 R-Delfino95 self-assigned this Apr 22, 2026
@vercel

vercel Bot commented Apr 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
media-chrome-demo-nextjs Ready Ready Preview, Comment Apr 23, 2026 6:46pm

Request Review

@ronald-urbina ronald-urbina merged commit 65d4394 into muxinc:main Apr 24, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Content shifts when <media-volume-range> control is tab-focused

2 participants