Skip to content

Docs/improve lang import and set#1287

Merged
ronald-urbina merged 3 commits into
muxinc:mainfrom
ronald-urbina:docs/improve-lang-import-and-set
Apr 15, 2026
Merged

Docs/improve lang import and set#1287
ronald-urbina merged 3 commits into
muxinc:mainfrom
ronald-urbina:docs/improve-lang-import-and-set

Conversation

@ronald-urbina

@ronald-urbina ronald-urbina commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Improve docs for adding/setting lang support and include German option to examples.


Note

Low Risk
Mostly documentation/example updates with a small additive API (resolvedLang/getResolvedLanguage) that should not affect existing behavior but could surface edge cases if consumers start relying on the resolved value.

Overview
Improves internationalization guidance by documenting script load order, manual lang overrides on <media-controller>, and how to contribute new language files; also updates the language list and examples (including German).

Enhances the vanilla i18n example to auto-select a best-match language from navigator.language, switch via a dropdown UI, and display both the detected browser language and the controller’s active resolved language.

Adds getResolvedLanguage() to utils/i18n and exposes it as a resolvedLang getter on MediaController so apps can query which language is actually being used after fallback resolution.

Reviewed by Cursor Bugbot for commit 47d2c6b. Bugbot is set up for automated code reviews on this repo. Configure here.

@ronald-urbina ronald-urbina requested review from a team and heff as code owners April 8, 2026 19:17
@vercel

vercel Bot commented Apr 8, 2026

Copy link
Copy Markdown

@ronalduQualabs is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@snyk-io

snyk-io Bot commented Apr 8, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov

codecov Bot commented Apr 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.55%. Comparing base (3ea80df) to head (47d2c6b).
⚠️ Report is 300 commits behind head on main.

Files with missing lines Patch % Lines
src/js/utils/i18n.ts 28.57% 5 Missing ⚠️
src/js/media-controller.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
- Coverage   78.55%   73.55%   -5.00%     
==========================================
  Files          59       56       -3     
  Lines       11080    13884    +2804     
  Branches        0      783     +783     
==========================================
+ Hits         8704    10213    +1509     
- Misses       2376     3638    +1262     
- Partials        0       33      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a8620c4. Configure here.

Comment thread examples/vanilla/internationalization.html
Comment thread examples/vanilla/internationalization.html
@ronald-urbina ronald-urbina merged commit d92d202 into muxinc:main Apr 15, 2026
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants