Skip to content

dts: msm8916: Add support for CMCC A1 (M623C) (Wingtech WT86621) - #725

Open
affggh wants to merge 1 commit into
msm8916-mainline:mainfrom
affggh:wt86621
Open

dts: msm8916: Add support for CMCC A1 (M623C) (Wingtech WT86621)#725
affggh wants to merge 1 commit into
msm8916-mainline:mainfrom
affggh:wt86621

Conversation

@affggh

@affggh affggh commented Jun 24, 2026

Copy link
Copy Markdown
lk2nd runs on Wingtech wt86621 It worked for me!

Comment thread lk2nd/device/dts/msm8916/msm8916-qrd-wt86621.dts Outdated
Comment thread lk2nd/device/dts/msm8916/msm8916-qrd-skul.dts
Comment thread lk2nd/device/dts/msm8916/msm8916-qrd-wt86621.dts Outdated
Comment thread lk2nd/device/dts/msm8916/rules.mk Outdated
$(LOCAL_DIR)/msm8939-qrd-skuk.dtb \
$(LOCAL_DIR)/msm8939-qrd-wt82918.dtb \
$(LOCAL_DIR)/msm8939-qrd-wt82918hd.dtb \
$(LOCAL_DIR)/msm8916-qrd-wt86621.dtb \

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not sorted alphabetically

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed it named msm8916-qrd-skul in decompiled device tree blob, so I rename it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused since i don't see sku L in the caf msm kernel from a quick look, vendors often do weird mess with the naming (i.e. sometimes they just modify existing file, or sometimes they copy them and leave stuff unchanged. Could you share the lines you've used to figure that out?

In any case, if this is a generic dtb, you'd have to find a match property, like in other generic dtbs then, as it'd imply some other oems could've easily copied it the same way...

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, It seems only wingtech open source kernel have this dts. And seems only this device use, I will change it back to wt86621.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind sharing a link to that kernel?

@affggh affggh Jul 18, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

msm8916-qrd-skul.dts

It seems from Xiaomi, and another lenovo opened source have fully skul.dts and dtsi.

lenovo k5 source

They are all from wingtech, so I guess I better rename it back to wt86621.dts

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the second source seems to have "skux" use the id=16, so it's probably a mess... Let's just name it as it's model for now but let's try adding device subnode and a match property so it's easier to reconcile multiple devices on this id later, if the need arises

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants