lk2nd: display: panel: generated: Add hx8394a_720p_video for vivo,pd1410#722
Merged
TravMurav merged 1 commit intoJun 25, 2026
Merged
Conversation
The vivo-pd1410 device added in msm8916-mainline#721 uses the hx8394a_720p_video panel, but the generated panel driver was not included alongside it. As a result, the lk1st build command documented for this device fails to link with an undefined reference to panel_hx8394a_720p_video_select. Add the generated panel driver and register it in panels.h. This is the panel driver part of msm8916-mainline#708; the device node itself was already merged via msm8916-mainline#721.
Contributor
Author
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The
vivo-pd1410device (Vivo Y27L / Y627 / Y927) added in #721 uses thehx8394a_720p_videopanel, but the generated panel driver was not included alongside the device node. As a result, the lk1st build command documented inmsm8916-vivo-cdp-1.dtsfor this device fails to link:lk2nd's
oem_panel.cselects the panel viapanel_select(LK2ND_DISPLAY), which expands topanel_hx8394a_720p_video_select(). This function is provided by the generated panel header, so the header is required — the gcdbpanel_hx8394a_720p_video.his filtered out bylk2nd/display/panel/rules.mkand does not participate in the build.This change adds the generated
lk_panel_hx8394a_720p_video.hdriver and registers it inpanels.h.Verification
Boot-tested on Vivo Y927 (PD1410V). The lk1st build command above now links successfully and produces
emmc_appsboot.mbn. The panel command sequences andpanel_hx8394a_720p_video_selectare confirmed present in the resulting binary.Related
vivo-pd1410device node itself was already merged via dts: msm8916: Clean up Vivo CDP #721.