Skip to content

lk2nd: hw: gpio: pm8921: Add devicetree flag for GPIO polarity inversion #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ejona86 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

lk2nd: hw: gpio: pm8921: Add devicetree flag for GPIO polarity inversion #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lk2nd/device/dts/msm8960/bundle.dts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@

volume-up {
lk2nd,code = <KEY_VOLUMEUP>;
gpios = <&pmic 3 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
gpios = <&pmic 3 (GPIO_ACTIVE_HIGH | GPIO_PMIC_INVERTED)>;
};
volume-down {
lk2nd,code = <KEY_VOLUMEDOWN>;
gpios = <&pmic 37 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
gpios = <&pmic 37 (GPIO_ACTIVE_HIGH | GPIO_PMIC_INVERTED)>;
};
};
};
Expand Down
1 change: 1 addition & 0 deletions lk2nd/hw/gpio/pm8921.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ int lk2nd_gpio_pmic_config(uint32_t num, int flags)
.function = !!(flags & GPIOL_FLAGS_ASSERTED),
.vin_sel = PMIC_FLAGS_VIN_SEL(flags),
.out_strength = clamp(GPIOL_CONF_DRVSTR(flags), 0, 3),
.inv_int_pol = !!(flags & PMIC_FLAGS_INVERTED),
};

if (flags & GPIO_PULL_UP)
Expand Down
1 change: 1 addition & 0 deletions lk2nd/hw/gpio/supplier.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

#define PMIC_FLAGS_VIN_SEL(x) BITS_SHIFT(num, 26, 24)
#define PMIC_NON_DEFAULT_VIN_SEL BIT(27)
#define PMIC_FLAGS_INVERTED BIT(28)

/* tlmm.c */
int lk2nd_gpio_tlmm_config(uint32_t num, int flags);
Expand Down
1 change: 1 addition & 0 deletions lk2nd/include/dt-bindings/lk2nd/gpio.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
/* 24:31 - Device-specific config flags */

#define GPIO_PMIC_VIN_SEL(x) (((x) & 0x07) << 24 | BIT(27)) /* bits 24:27 */
#define GPIO_PMIC_INVERTED BIT(28)

/* device-specific definitions */

Expand Down
Loading