Add Samsung Galaxy Tab S2 8.0 (2016) support#709
Open
jdkjkjj wants to merge 5 commits into
Open
Conversation
| - Samsung Galaxy Tab A 8.0 (2015) - SM-T350, SM-T355, SM-T355Y, SM-T357W | ||
| - Samsung Galaxy Tab A 9.7 (2015) - SM-T550, SM-T555 | ||
| - Samsung Galaxy Tab E 9.6 WiFi (2015) - SM-T560NU | ||
| - Samsung Galaxy Tab S2 8.0 WiFi (2016) - SM-T713 |
Contributor
There was a problem hiding this comment.
Not here. Move this to lk2nd-msm8952.
Comment on lines
+7
to
+8
| qcom,msm-id = <QCOM_ID_MSM8976 0x10001>; | ||
| qcom,board-id = <QCOM_BOARD_ID_QRD 0x0>; |
Contributor
There was a problem hiding this comment.
Currently duplicated with msm8976-qrd. You might want to edit msm8976-qrd instead.
| compatible = "samsung,gts28vewifi"; | ||
|
|
||
| lk2nd,match-bootloader = "*T713*"; | ||
| lk2nd,match-panel; |
Contributor
There was a problem hiding this comment.
You don't need this when there is lk2nd,match-bootloader.
Comment on lines
+51
to
+57
| panel { | ||
| compatible = "samsung,gts28vewifi-panel", "lk2nd,panel"; | ||
|
|
||
| ss_dsi_panel_S6E3HA2_AMS801HK01_QXGA { | ||
| compatible = "samsung,gts28vewifi-s6e3ha2"; | ||
| }; | ||
| }; |
Contributor
There was a problem hiding this comment.
Ditto. Or are there more panel variants?
samcday
reviewed
Jun 19, 2026
| $(LOCAL_DIR)/qm215-mtp.dtb \ | ||
|
|
||
| QCDTBS += \ | ||
| $(LOCAL_DIR)/msm8976-gts28vewifi.dtb \ |
Contributor
There was a problem hiding this comment.
Strange that this DTB is being added to ADTBS as well as QCDTBS. I think it's worth documenting why this is necessary as a comment here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the dts