lk2nd: Add support for OPPO A33 (ql790)#699
Conversation
| * | ||
| * Board-IDs from downstream CAF kernel DTS (oppo-a33-master): | ||
| * A33: <0x21010b 5>, <0x22010b 5>, <0x23010b 5>, <0x1000b 5>, <0x1000b 0> | ||
| * A33m: <0x1010b 7>, <0x1000b 5>, <0x1010b 5>, <0x3010b 5> |
There was a problem hiding this comment.
<0x1000b 5>, <0x1010b 5>, <0x3010b 5> is used by msm8916-qrd-skui by the way.
There was a problem hiding this comment.
Fixed, kept only unique board-ids. A33m dropped due to conflicts.
| qcom,board-id = <0x21010b 5>, | ||
| <0x22010b 5>, | ||
| <0x23010b 5>, | ||
| <0x1000b 5>, |
There was a problem hiding this comment.
<0x1000b 5> conflicts with msm8916-qrd-skui.
| * A33: <0x21010b 5>, <0x22010b 5>, <0x23010b 5>, <0x1000b 5>, <0x1000b 0> | ||
| * A33m: <0x1010b 7>, <0x1000b 5>, <0x1010b 5>, <0x3010b 5> |
There was a problem hiding this comment.
The values of board-id doesn't overlap a lot and it could have been split into 2 devices trees.
TravMurav
left a comment
TravMurav
left a comment
There was a problem hiding this comment.
also squash all commits into one. If you haven't yet tested this on real hardware, please make this into a draft until you've done
| }; | ||
|
|
||
| &lk2nd { | ||
| model = "OPPO A33"; |
There was a problem hiding this comment.
Should be added to Documentation/devices.md
| qcom,board-id = <0x21010b 5>, | ||
| <0x22010b 5>, | ||
| <0x23010b 5>; |
There was a problem hiding this comment.
Which one your device actually needs? Let's for now keep only the on without which the device doesn't boot.
| - Motorola Moto E (2015) - surnia | ||
| - Motorola Moto G (2015) - osprey | ||
| - Motorola Moto G4 Play - harpia | ||
| - OPPO A33 (ql790) - William-Practice |
There was a problem hiding this comment.
is this really the device codename?
|
Allright OPPO A33 has no its codename
|
Yeah Co-authored-by: Raymond Hackley <raymondhackley@protonmail.com>
3 participants
WIP: need testing on actual hardware