-
Notifications
You must be signed in to change notification settings - Fork 477
Implement support for TP-Link M7350 V3 (MDM9625) #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
2ee0a6d
02d1f69
17bdf5b
83abc26
b60ea2b
486e2c9
8bf4c3b
703e9a9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| // SPDX-License-Identifier: BSD-3-Clause | ||
|
|
||
| #include <skeleton64.dtsi> | ||
| #include <lk2nd.dtsi> | ||
|
|
||
| / { | ||
| qcom,msm-id = <134 7 0x20001>, <152 7 0x20001>, <149 7 0x20001>, | ||
| <150 7 0x20001>, <151 7 0x20001>, <148 7 0x20001>, | ||
| <173 7 0x20001>, <174 7 0x20001>, <175 7 0x20001>; | ||
|
Comment on lines
+7
to
+9
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder if those msm-ids (134, 152...) are documented somewhere so we could've added them to qcom,ids.h and used here then
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. some are definitely documented in downstream but I think I remember some missing |
||
| }; | ||
|
|
||
| &lk2nd { | ||
| tp-link-m7350-v3 { | ||
| model = "TP-Link M7350"; | ||
| compatible = "tplink,m7350-v3"; | ||
|
|
||
| gpio-keys { | ||
| compatible = "gpio-keys"; | ||
|
|
||
| menu { | ||
| lk2nd,code = <KEY_HOME>; | ||
| gpios = <&tlmm 14 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; | ||
| }; | ||
|
|
||
| reset { | ||
| lk2nd,code = <KEY_HOME>; | ||
| gpios = <&tlmm 15 (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>; | ||
| }; | ||
| }; | ||
| }; | ||
| }; | ||
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,4 @@ | ||||||||
| LOCAL_DIR := $(GET_LOCAL_DIR) | ||||||||
|
|
||||||||
| QCDTBS += \ | ||||||||
| $(LOCAL_DIR)/msm9625-v2.1-mtp.dtb | ||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
so future diffs are smaller |
||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,7 +3,6 @@ LOCAL_DIR := $(GET_LOCAL_DIR) | |
|
|
||
| OBJS += \ | ||
| $(LOCAL_DIR)/fetch.o \ | ||
| $(LOCAL_DIR)/hash.o \ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. probably needs some ifneq on some condition for crypto module existing, like for screenshot below, no need to bother implementing crypto for now, this tool was mainly added for testing |
||
| $(LOCAL_DIR)/misc.o \ | ||
|
|
||
| ifneq ($(filter DISPLAY_SPLASH_SCREEN=1,$(DEFINES)),) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # SPDX-License-Identifier: BSD-3-Clause | ||
| TARGET := mdm9625 | ||
| include lk2nd/project/lk2nd.mk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk if we really tried to keep this consistent honestly but maybe