dts: msm8952: dts for Readboy G500X (g500x)#684
Conversation
S-lkno
commented
May 4, 2026
S-lkno
commented
|
|
||
| / { | ||
| qcom,msm-id = <QCOM_ID_MSM8937 0>; | ||
| qcom,board-id = <0x2000b 0>; |
There was a problem hiding this comment.
seems like I've missed it but this looks like QCOM_BOARD_ID(QRD, 2, 0)
Since you already have match-device, I assume your cmdline has the "g500x" in it, so we can trivially convert this to multi-device file. Please replace the const with a macro as suggested, rename the file to msm8937-pmi8950-qrd-sku1.dts and put your device information into a subnode under lk2nd node, i.e. like it's done here:
https://github.com/msm8916-mainline/lk2nd/blob/main/lk2nd/device/dts/msm8952/msm8952-mtp.dts
This way if we have to add other device with the same ID to this file, we will be able to do it trivially and without breaking yours
There was a problem hiding this comment.
This comment still stands, we can't really make this into a single-device dts since the OEM reused a generic msm-id, so it's possible some other device exists that has same msm-id, and if someone wants to add it, they won't be able to without possibly breaking yours. To make sure this won't happen, you need to make this into a multi-device dts with appropriate name
|
Thanks for the review. I'm new to this, and I appreciate the guidance. The match-device property was added by mistake and has been removed. This dts is for a single device only. |
|
Thanks. I realize I've been rushing this. I'll take some time to learn more and come back to this later. |
|
I've tested the subnode format with both match-device and qcom,board-id in the subnode. It consistently fails because the stock bootloader does not pass any androidboot.device parameter in the cmdline, and the board-id matching in subnodes doesn't trigger on this device. The only working configuration is with the properties directly under &lk2nd. I've applied the macro and renamed the file as requested. Given the hardware limitations, this is the only viable format. Please let me know if you have any alternative approach that I can test. |
If there is nothing useful in cmdline, you can still use the match-panel rule as a last resort, would you mind trying that? |
|
Of course I'd be willing to give it a try, but I don't know what Match-Panel means? , to recognize the screen? There are several panels in the DTB of this device, I need to ask, if you don't mind |
Please see https://github.com/msm8916-mainline/lk2nd/blob/main/Documentation/dt-bindings.md#match-property If you can find one of the properties in the list that work instead of match-panel that would be perfect (or if unsure, feel free to share cmdline string that lk2nd sees, you can find it in lk2nd log). If you have to add match-panel anyway, take care if you're using decompiled dtb since some vendors don't delete "default" test panels, you want to include those which match resolution of your device, and not things like simulated panel etc... |
2 participants
