Add support for Lenovo Tab 2 A10-30#603
Open
kucer0043 wants to merge 6 commits into
Open
Conversation
Comment on lines
+8
to
+9
| qcom,msm-id = <0xf5 0x00>; | ||
| qcom,board-id = <0x1000b 0x08 0x11000b 0x08 0x21000b 0x08>; |
Contributor
There was a problem hiding this comment.
qcom,msm-id = <QCOM_ID_MSM8909 0>;
qcom,board-id = <QCOM_BOARD_ID(QRD, 0x01, 0) 0x8>,
<QCOM_BOARD_ID(QRD, 0x11, 0) 0x8>,
<QCOM_BOARD_ID(QRD, 0x21, 0) 0x8>;
It's identical to msm8909-1gb-qrd-skuc and we can move this device to it. We cannot have 2 device trees with identical ids either way.
| }; | ||
|
|
||
| lenovo-achilles { | ||
| model = "Lenovo Tab 2 A10-30 (Achilles)"; |
Contributor
There was a problem hiding this comment.
Is it a WiFi only tablet by the way?
Author
There was a problem hiding this comment.
There are two models of this tablet:
- TB2-X30L - With wifi and mobile connection (I tested on it)
- TB2-X30F - WiFi only
Member
There was a problem hiding this comment.
it might be worth adding L to this device model description, depending on whether the wifi version would be able to match on 8909 chip, or it would only match the wifi-only 8009
TravMurav
reviewed
Nov 14, 2025
TravMurav
left a comment
TravMurav
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay, one small comment
| }; | ||
|
|
||
| lenovo-achilles { | ||
| model = "Lenovo Tab 2 A10-30 (Achilles)"; |
Member
There was a problem hiding this comment.
Would you mind adding this device to the Documentation/devices.md list?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.