Add support for setting OS version and patch level and add new Palm Phone device#579
Add support for setting OS version and patch level and add new Palm Phone device#579xc-racer99 wants to merge 2 commits into
Conversation
Some bootloaders check that there is valid in the OS version and/or patch level fields of the Android boot.img. Add the ability to specify them.
TravMurav
left a comment
TravMurav
left a comment
There was a problem hiding this comment.
Hi! Sorry for the delay. The changes look good to me apart from one comment below
| model = "Palm Phone (pepito)"; | ||
| compatible = "palm,pepito"; | ||
|
|
||
| lk2nd,dtb-files = "qcom,msm8940-mtp", "qcom,msm8940", "qcom,mtp"; |
There was a problem hiding this comment.
This line should define a dtb filename for this device, not a list of compatibles (especially downstream ones), which would be used for booting a generic linux image with extlinux.conf. If you have some work to run linux on this device, please put the name of your dtb here
lk2nd/Documentation/dt-bindings.md
Lines 67 to 69 in 4801a1e
There was a problem hiding this comment.
Ah, I misinterpreted what this line was for - thanks! I haven't (yet) had a chance to do a mainline linux port. Since that's the case, should the property just be deleted?
There was a problem hiding this comment.
If you believe you know what the dtb name should be, you can add it, and we can fix it later if upstream wants the filename changed. Otherwise some devices define it as a comment with a best guess (can grep for FIXME in the dts dir)
3 participants
The Palm phone bootloader has a few quirks, so need to add some code to set the OS version and patch level in the generated lk2nd image. Then add support for the device itself. It only has a single power button, so use the short/long press control for it.