snappymail: fix nginx root and /snappymail prefix handling - #690
Closed
Infern1 wants to merge 1 commit into
Closed
Conversation
Owner
|
I can't replicate the issue on an upgrade nor on a completely new build. Without these changes, the install works just fine. Even if it hadn't, changing the |
Collaborator
Author
|
So I never deployed snappymail, switch to using it, since rainloop is not maintained. Yesterday I updated to base p8 The gist And now I retried and it is working, really strange |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
With
root /usr/local/www, both paths resolve:/snappymail/→/usr/local/www/snappymail/index.php, and assets built fromapp_path = "/snappymail"→/snappymail/snappymail/v/<ver>/static/...→/usr/local/www/snappymail/snappymail/v/....Note for existing installs:
store_config()won't overwrite an existingsnappymail.conf, so this only helps fresh deploys.roundcube.shhandlesthat case with
migrate_roundcube_nginx_conf()— happy to add an equivalenthere if you want it, though moving people's configs felt like your call.
Fixes #689
Checklist: