Bug 2040784 - Introduce AIFeatureState to handle the "Unknown" states… - #274
Closed
MatthewTighe wants to merge 1 commit into
Closed
Bug 2040784 - Introduce AIFeatureState to handle the "Unknown" states…#274MatthewTighe wants to merge 1 commit into
MatthewTighe wants to merge 1 commit into
Conversation
… of AI controls This fixes the issue in bug 2040784 by ensuring that we have an unknown state where we don't know yet if the feature is enabled or not. This becomes important when we need to know if the user turned a feature on explicitly, or it was on by default, or they just never never interacted with the feature.
Contributor
|
Warning The base branch is currently set to |
Contributor
|
View this pull request in Lando to land it once approved. |
boek
approved these changes
May 29, 2026
boek
left a comment
boek
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me. Is it easy to check this fix in the s2s case to verify the CFR isn't shown?
lando-worker Bot
pushed a commit
that referenced
this pull request
May 30, 2026
…… r=boek … of AI controls This fixes the issue in bug 2040784 by ensuring that we have an unknown state where we don't know yet if the feature is enabled or not. This becomes important when we need to know if the user turned a feature on explicitly, or it was on by default, or they just never never interacted with the feature. I commandeered this from Segun. Only downstream changes from me were to swap to the IO dispatcher while collecting the storage flow in the registry and a cosmetic change to remove the text fixtures he introduced in favor of the existing `inMemory` factories. Pull request: #274
|
Pull request closed by commit 26c1fbc |
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jun 1, 2026
…… r=boek … of AI controls This fixes the issue in bug 2040784 by ensuring that we have an unknown state where we don't know yet if the feature is enabled or not. This becomes important when we need to know if the user turned a feature on explicitly, or it was on by default, or they just never never interacted with the feature. I commandeered this from Segun. Only downstream changes from me were to swap to the IO dispatcher while collecting the storage flow in the registry and a cosmetic change to remove the text fixtures he introduced in favor of the existing `inMemory` factories. Pull request: mozilla-firefox/firefox#274 UltraBlame original commit: 2f6f9d8fa5263e68eb27d229e5ace31c90a0166f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jun 1, 2026
…… r=boek … of AI controls This fixes the issue in bug 2040784 by ensuring that we have an unknown state where we don't know yet if the feature is enabled or not. This becomes important when we need to know if the user turned a feature on explicitly, or it was on by default, or they just never never interacted with the feature. I commandeered this from Segun. Only downstream changes from me were to swap to the IO dispatcher while collecting the storage flow in the registry and a cosmetic change to remove the text fixtures he introduced in favor of the existing `inMemory` factories. Pull request: mozilla-firefox/firefox#274 UltraBlame original commit: 2f6f9d8fa5263e68eb27d229e5ace31c90a0166f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jun 1, 2026
…… r=boek … of AI controls This fixes the issue in bug 2040784 by ensuring that we have an unknown state where we don't know yet if the feature is enabled or not. This becomes important when we need to know if the user turned a feature on explicitly, or it was on by default, or they just never never interacted with the feature. I commandeered this from Segun. Only downstream changes from me were to swap to the IO dispatcher while collecting the storage flow in the registry and a cosmetic change to remove the text fixtures he introduced in favor of the existing `inMemory` factories. Pull request: mozilla-firefox/firefox#274 UltraBlame original commit: 2f6f9d8fa5263e68eb27d229e5ace31c90a0166f
akliuxingyuan
pushed a commit
to akliuxingyuan/android-components
that referenced
this pull request
Jul 25, 2026
…… r=boek … of AI controls This fixes the issue in bug 2040784 by ensuring that we have an unknown state where we don't know yet if the feature is enabled or not. This becomes important when we need to know if the user turned a feature on explicitly, or it was on by default, or they just never never interacted with the feature. I commandeered this from Segun. Only downstream changes from me were to swap to the IO dispatcher while collecting the storage flow in the registry and a cosmetic change to remove the text fixtures he introduced in favor of the existing `inMemory` factories. Pull request: mozilla-firefox/firefox#274
akliuxingyuan
pushed a commit
to fork-maintainers/iceraven-browser
that referenced
this pull request
Jul 25, 2026
…… r=boek … of AI controls This fixes the issue in bug 2040784 by ensuring that we have an unknown state where we don't know yet if the feature is enabled or not. This becomes important when we need to know if the user turned a feature on explicitly, or it was on by default, or they just never never interacted with the feature. I commandeered this from Segun. Only downstream changes from me were to swap to the IO dispatcher while collecting the storage flow in the registry and a cosmetic change to remove the text fixtures he introduced in favor of the existing `inMemory` factories. Pull request: mozilla-firefox/firefox#274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… of AI controls
This fixes the issue in bug 2040784 by ensuring that we have an unknown state where we don't know yet if the feature is enabled or not. This becomes important when we need to know if the user turned a feature on explicitly, or it was on by default, or they just never never interacted with the feature.
I commandeered this from Segun. Only downstream changes from me were to swap to the IO dispatcher while collecting the storage flow in the registry and a cosmetic change to remove the text fixtures he introduced in favor of the existing
inMemoryfactories.