Bug 2042222 - Wired up passwords import flow - #266
Conversation
|
View this pull request in Lando to land it once approved. |
![mozilla-code-review[bot]](https://avatars.githubusercontent.com/in/3631945?s=60&v=4){kind=small}
| override suspend fun importPasswordsFromUri(uri: Uri): Result<ImportResult> = runCatching { | ||
| val inputStream = uriOpener.open(uri).getOrThrow() | ||
| val parseResult = inputStream.use { parser.parse(it) }.getOrThrow() | ||
| val imported = parseResult.logins.count { entry -> |
There was a problem hiding this comment.
This needs to be updated to use the addmany that jeff added the bindings for once it is added to storage in fenix
| viewLifecycleOwner, | ||
| ) { _, bundle -> | ||
| if (ImportPasswordsDialogFragment.decodeResult(bundle) is PasswordsImporterResult.Success) { | ||
| loginsStore?.dispatch(LoginsListAppeared) |
There was a problem hiding this comment.
does onViewCreated get called coming back to this list? I'm curious why we need another loginsStore?.dispatch(LoginsListAppeared)
There was a problem hiding this comment.
Yes but the collection is scoped to viewLifecycleOwner so it isnt a problem when navigating away and returning. We need to setup the collection somewhere to ensure the page updates after a import completes.
09576cf to
74d903e
Compare
This review is now deprecated.
|
Previous issues have been fixed. This pull request is 🆗 |
74d903e to
355c302
Compare
|
No new issues detected. This pull request is 🆗 |
355c302 to
a07fd16
Compare
|
No new issues detected. This pull request is 🆗 |
|
Pull request closed by commit 2b7f299 |
2 participants
https://treeherder.mozilla.org/jobs?repo=try&landoInstance=lando-prod-2025&landoCommitID=50041