Bug 2037736 - Added components cache for data store backed settings - #265
Closed
fmasalha wants to merge 1 commit into
Closed
Bug 2037736 - Added components cache for data store backed settings#265fmasalha wants to merge 1 commit into
fmasalha wants to merge 1 commit into
Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
fmasalha
force-pushed
the
ai-settings-cache
branch
from
May 25, 2026 09:57
3f2ae5b to
da2fcc9
Compare
![mozilla-code-review[bot]](https://avatars.githubusercontent.com/in/3631945?s=60&v=4){kind=small}
Contributor
Author
fmasalha
force-pushed
the
ai-settings-cache
branch
from
May 26, 2026 08:55
da2fcc9 to
252c8db
Compare
Contributor
Author
|
@boek Would it be better to just convert the interfaces to use a stateflow instead? It feels to me that we are wrapping them to convert them to stateflows when we can just bake the stateflows into the implementations that already exist. |
fmasalha
force-pushed
the
ai-settings-cache
branch
from
May 26, 2026 09:42
252c8db to
ce1ac5e
Compare
Contributor
|
@fmasalha are you talking about the |
boek
approved these changes
May 27, 2026
fmasalha
force-pushed
the
ai-settings-cache
branch
from
June 1, 2026 16:30
ce1ac5e to
d7ef7db
Compare
Contributor
Author
fmasalha
force-pushed
the
ai-settings-cache
branch
from
June 1, 2026 17:37
d7ef7db to
ff2aa8b
Compare
mozilla-code-review
Bot
dismissed
their stale review
June 1, 2026 19:27
This review is now deprecated.
fmasalha
force-pushed
the
ai-settings-cache
branch
from
June 2, 2026 16:09
ff2aa8b to
7b3cad3
Compare
Contributor
Author
|
@boek I re requested review since the patch had some changes due to merge conflicts and also android reviewers is now tagged on the patch. Thank you! |
mozilla-code-review
Bot
dismissed
their stale review
June 2, 2026 18:16
This review is now deprecated.
|
Previous issues have been fixed. This pull request is 🆗 |
boek
approved these changes
Jun 4, 2026
fmasalha
force-pushed
the
ai-settings-cache
branch
from
June 9, 2026 04:27
7b3cad3 to
a14fda4
Compare
boek
approved these changes
Jun 9, 2026
fmasalha
force-pushed
the
ai-settings-cache
branch
from
June 9, 2026 04:49
a14fda4 to
6035531
Compare
|
No new issues detected. This pull request is 🆗 |
|
Pull request closed by commit 0ed11a3 |
lando-worker Bot
pushed a commit
that referenced
this pull request
Jun 9, 2026
…=boek Pull request: #265
akliuxingyuan
pushed a commit
to akliuxingyuan/android-components
that referenced
this pull request
Jul 25, 2026
akliuxingyuan
pushed a commit
to fork-maintainers/iceraven-browser
that referenced
this pull request
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.