Skip to content

Bug 2040748 - Implemented PasswordFileParser - #260

Closed
fmasalha wants to merge 1 commit into
mozilla-firefox:autolandfrom
fmasalha:csv-passwords-parser
Closed

Bug 2040748 - Implemented PasswordFileParser#260
fmasalha wants to merge 1 commit into
mozilla-firefox:autolandfrom
fmasalha:csv-passwords-parser

Conversation

@fmasalha

Copy link
Copy Markdown
Contributor

https://treeherder.mozilla.org/jobs?repo=try&revision=86fb33ab3b068904316aacf8160a46a7066a6b7e

The parse is inspired by https://searchfox.org/firefox-main/source/toolkit/components/passwordmgr/CSV.sys.mjs

I exported and added tests based off the following password managers; 1Password, Bitwarden, Chrome, Dashlane, Firefox Desktop, LastPass, Safari.

@github-actions

Copy link
Copy Markdown
Contributor

View this pull request in Lando to land it once approved.

@Alexandra-Virvara Alexandra-Virvara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@fmasalha
fmasalha force-pushed the csv-passwords-parser branch from a8a0b57 to bc3d833 Compare May 25, 2026 08:20
@fmasalha
fmasalha force-pushed the csv-passwords-parser branch from bc3d833 to 3990576 Compare May 25, 2026 09:33
@lando-worker

lando-worker Bot commented May 25, 2026

Copy link
Copy Markdown

Pull request closed by commit e57d502

lando-worker Bot pushed a commit that referenced this pull request May 25, 2026
…lla-code-review[bot]

https://treeherder.mozilla.org/jobs?repo=try&revision=86fb33ab3b068904316aacf8160a46a7066a6b7e

The parse is inspired by https://searchfox.org/firefox-main/source/toolkit/components/passwordmgr/CSV.sys.mjs

I exported and added tests based off the following password managers; 1Password, Bitwarden, Chrome, Dashlane, Firefox Desktop, LastPass, Safari.

Pull request: #260
@lando-worker lando-worker Bot closed this May 25, 2026
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request May 26, 2026
…lla-code-review[bot]

https://treeherder.mozilla.org/jobs?repo=try&revision=86fb33ab3b068904316aacf8160a46a7066a6b7e

The parse is inspired by https://searchfox.org/firefox-main/source/toolkit/components/passwordmgr/CSV.sys.mjs

I exported and added tests based off the following password managers; 1Password, Bitwarden, Chrome, Dashlane, Firefox Desktop, LastPass, Safari.

Pull request: mozilla-firefox/firefox#260

UltraBlame original commit: d2760b46de6f02d507509234362fd83043da4ef3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request May 26, 2026
…lla-code-review[bot]

https://treeherder.mozilla.org/jobs?repo=try&revision=86fb33ab3b068904316aacf8160a46a7066a6b7e

The parse is inspired by https://searchfox.org/firefox-main/source/toolkit/components/passwordmgr/CSV.sys.mjs

I exported and added tests based off the following password managers; 1Password, Bitwarden, Chrome, Dashlane, Firefox Desktop, LastPass, Safari.

Pull request: mozilla-firefox/firefox#260

UltraBlame original commit: d2760b46de6f02d507509234362fd83043da4ef3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request May 26, 2026
…lla-code-review[bot]

https://treeherder.mozilla.org/jobs?repo=try&revision=86fb33ab3b068904316aacf8160a46a7066a6b7e

The parse is inspired by https://searchfox.org/firefox-main/source/toolkit/components/passwordmgr/CSV.sys.mjs

I exported and added tests based off the following password managers; 1Password, Bitwarden, Chrome, Dashlane, Firefox Desktop, LastPass, Safari.

Pull request: mozilla-firefox/firefox#260

UltraBlame original commit: d2760b46de6f02d507509234362fd83043da4ef3
akliuxingyuan pushed a commit to akliuxingyuan/android-components that referenced this pull request Jul 25, 2026
…lla-code-review[bot]

https://treeherder.mozilla.org/jobs?repo=try&revision=86fb33ab3b068904316aacf8160a46a7066a6b7e

The parse is inspired by https://searchfox.org/firefox-main/source/toolkit/components/passwordmgr/CSV.sys.mjs

I exported and added tests based off the following password managers; 1Password, Bitwarden, Chrome, Dashlane, Firefox Desktop, LastPass, Safari.

Pull request: mozilla-firefox/firefox#260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants