fix: make config file parsing stricter and support config includes - #937
Open
matchaxnb wants to merge 1 commit into
Open
fix: make config file parsing stricter and support config includes#937matchaxnb wants to merge 1 commit into
matchaxnb wants to merge 1 commit into
Conversation
- now support comments at the end of lines - trims values of their trailing whitespaces - refactor error handling in args and config so that all errors are caught at once (alas, uses a global var in the config module, but it's fair ig) - safer integer parsing (atoi is known to not care at all for errors) - error status is now a bool flag carried around, so parser functions are void ...() - update moonlight.conf with a bit of docs to be explicit about parsing format
Author
|
Fixes #935 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve the config parsing and documentation around it.
Purpose